Opened 13 years ago

Closed 13 years ago

#2337 closed Enhancement (fixed)

GTK+ Tree view columns in the files dialog should be resizable

Reported by: lethalman Owned by: charles
Priority: Normal Milestone: 1.74
Component: GTK+ Client Version: 1.73
Severity: Normal Keywords:
Cc: lethalman88@…

Description

Hello, having tree view columns resizable is important, say for displaying the whole file names. It's very trivial to fix. Just add gtk_tree_view_column_set_resizable(column, TRUE); to all columns under file-list.c and, if possible, to all other tree views.

Attachments (2)

resizable.patch (4.2 KB) - added by lethalman 13 years ago.
resizable2.patch (1.5 KB) - added by lethalman 13 years ago.
filename resizable and other columns fixed

Download all attachments as: .zip

Change History (13)

comment:1 Changed 13 years ago by lethalman

  • Cc lethalman88@… added

comment:2 Changed 13 years ago by charles

  • Resolution set to wontfix
  • Status changed from new to closed
  • Summary changed from GTK+ Tree view columns in the files dialog must be resizable to GTK+ Tree view columns in the files dialog should be resizable

I've already been through that :)

The reason that they're no longer resizable is because doing so triggers a bug that's frustrated many users, where they're stuck in resize mode and can't escape and can't click on anything.

Here's a demonstration of that bug in action after adding the simple resizable( TRUE ) lines as suggested: http://www.youtube.com/watch?v=i0X2INWVsto

comment:3 Changed 13 years ago by charles

  • Type changed from Bug to Enhancement

comment:4 Changed 13 years ago by lethalman

So you decided to remove the feature instead of fixing the bug, like many other software do, right? That's a bug of transmission-gtk or gtk? Because it never happened to me with other applications.

comment:5 Changed 13 years ago by charles

Feel free to submit a patch if you know how to fix it.

comment:6 Changed 13 years ago by lethalman

  • Resolution wontfix deleted
  • Status changed from closed to reopened

Fix attached:

  1. No need for fixed size rows, you are not displaying a large dataset (usually it's needed for miles of rows, and the difference is not as big as you think, so don't think it's useful).
  2. The problem was the released event to return TRUE; when items have been unselected. I've removed it because there's no logic/need in catching the event after all items have been unselected.

Thanks for considering the bug, I'm reopening it. Fell free to close it again if you don't think it's worth applying the patch. However keep in mind that it's really annoying to not view the whole filename you are going to download, especially when ellipsize to end is set.

Changed 13 years ago by lethalman

comment:7 Changed 13 years ago by charles

Don't misunderstand me -- I just want things to work well and not throw any roadblocks in the way of the user.

Thanks for taking the time to track down this bug.

I'd appreciate it if you'd take a look at a new one that your patch raises, so that we don't wind up trading one ui wart for another. When opening a file list under your patch, almost all of the "priority" column is obscured, making the priorities difficult to set and impossible to read without resizing the window. It would be better if this column were fully visible by default as in 1.73.

comment:8 Changed 13 years ago by charles

This is what comes up by default now when you open a file list. Note the priority column is nearly completely obscured.

http://imgur.com/2VtLH.png

comment:9 Changed 13 years ago by lethalman

You're completely right. The next patch makes resizable the filename column while keeping fixed the others (which is still meaningful). The result looks like right the same as before.

Changed 13 years ago by lethalman

filename resizable and other columns fixed

comment:10 Changed 13 years ago by charles

  • Milestone changed from None Set to 1.74

Looks great. Thanks for the quick revision. :)

comment:11 Changed 13 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in trunk by r8941 for 1.74

Note: See TracTickets for help on using tickets.