Opened 13 years ago

Closed 13 years ago

#2347 closed Enhancement (duplicate)

More fine-grained progress measurement

Reported by: mortennorby Owned by: charles
Priority: Normal Milestone: None Set
Component: libtransmission Version: 1.73
Severity: Normal Keywords:
Cc:

Description

The Inspector panel's Activity tab shows an 18x18 grid with an overview of the progress of the download, represented by a color scale from white to dark blue, with an orange flash when a piece is completed.

The information for this display is sampled from from the list of pieces. This means that for a torrent with, e.g., 5000 pieces, the progress is measured on ~6.5% (=18x18/5000) of the total file.

This can lead to inconsistences with the file tab, if a whole sequence of pieces is shown as completed in the graphical representation, while the file view reports some of the files at less than 100%.

Proposal: Provide a more accurate measurement to help users better understand the progress of a download.

Patch: Attached are two patches that calculate the progress more accurately to reach the goal of this proposal.

completion.diff is a patch for libtransmission/completion.c and makes the percent-wise progress measure more accurate.

peer-mgr.diff is a patch for libtransmission/peer-mgr.c and does the same thing for the availability, plus it makes sure that the criteria for completeness is identical between the two views in the Activity tab.

Attachments (3)

completion.diff (2.0 KB) - added by mortennorby 13 years ago.
A more accurate percent-wise progress measurement.
peer-mgr.diff (2.1 KB) - added by mortennorby 13 years ago.
A more accurate availability measurement, matching completion.diff.
nosample.diff (4.8 KB) - added by mortennorby 13 years ago.
Unified diff with all the changes

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by mortennorby

A more accurate percent-wise progress measurement.

Changed 13 years ago by mortennorby

A more accurate availability measurement, matching completion.diff.

comment:1 Changed 13 years ago by charles

could you create a single unified diff ("diff -u") of all the changes?

Changed 13 years ago by mortennorby

Unified diff with all the changes

comment:2 Changed 13 years ago by charles

  • Resolution set to duplicate
  • Status changed from new to closed

folding this ticket into #2352

Note: See TracTickets for help on using tickets.