Opened 15 years ago

Closed 14 years ago

#238 closed Defect (fixed)

If warranted, ban peers, not just pieces

Reported by: jah Owned by: charles
Priority: Normal Milestone: 0.90
Component: libtransmission Version: 0.72
Severity: Normal Keywords:
Cc:

Description

The current auto ban implementation only prevents T from downloading pieces it has learned are corrupt from that peer. However, if all a given peers pieces are corrupt, T will continue to download from that peer, slowly banning individual pieces until all are banned. This wastes bandwidth, as T may download all the pieces from that peer, only to hash fail them, and in turn ban each piece.

At some point (say after a certain number of banned pieces), T should realise that the entire peer is corrupted, not just certain pieces from that peer. It should then ban that peer, rather than continuing to download new (most likely corrupted) pieces from it. This is a much more efficient method.

Change History (7)

comment:1 Changed 15 years ago by livings124

  • Severity changed from blocker to normal

comment:2 Changed 15 years ago by livings124

  • Version 0.6 deleted

comment:3 Changed 15 years ago by charles

  • Owner changed from somebody to charles
  • Status changed from new to assigned
  • Version set to 0.72

comment:4 Changed 15 years ago by charles

  • Component changed from Transmission to libtransmission

comment:5 Changed 15 years ago by charles

  • Type changed from Defect to Enhancement

comment:6 Changed 14 years ago by persept

  • Type changed from Enhancement to Defect

IMO this is a defect because in certain situations it makes normal operation impossible. If the torrent is poisoned with bad data, downloading the complete torrent is impossible.

comment:7 Changed 14 years ago by charles

  • Milestone changed from Sometime to 0.90
  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in r3318

Note: See TracTickets for help on using tickets.