Azureus reports bad PEX packages from Transmission 0.72

[adament]

I haven't yet tried Transmission, I actually had never heard of it before until I noticed the following in my Azureus log:

Invalid PEX message received: too large [53/-1]R: **.**.**.***: 56439 [Transmission 0.72]
Invalid PEX message received: too large [54/-1]R: **.**.**.***: 32878 [Transmission 0.72]
Invalid PEX message received: too large [53/-1]R: **.**.**.***: 57279 [Transmission 0.72]

I just thought this might be of some use to you.

[charles]

This message is sent by PEPeerTransportProtocol.java when we send more than MAX_PEERS_PER_VOLLEY peers in our added or dropped list. PeerExchangerItem?.java:

public static final int MAX_PEERS_PER_VOLLEY = 50;

[charles]

Looks like the fix would need to be made in makeCommonPex() in peerext.h

[joshe]

Untested patch to limit utorrent and azureus pex messages to 50 peers

[charles]

joshe: there seems to be a bug in this patch. One block reads, in essence, "while( count < PEX_MAX_PEERS ) { doSomething(); count--; }" s.t. the loop will never end... unless I'm reading something wrong...

[anonymous]

Milestone 0.81 deleted