Opened 15 years ago

Closed 14 years ago

#243 closed Defect (invalid)

Azureus reports bad PEX packages from Transmission 0.72

Reported by: adament Owned by: charles
Priority: High Milestone: 0.90
Component: libtransmission Version: 0.72
Severity: Normal Keywords: PEX
Cc:

Description (last modified by John Clay)

I haven't yet tried Transmission, I actually had never heard of it before until I noticed the following in my Azureus log:

Invalid PEX message received: too large [53/-1]R: **.**.**.***: 56439 [Transmission 0.72]
Invalid PEX message received: too large [54/-1]R: **.**.**.***: 32878 [Transmission 0.72]
Invalid PEX message received: too large [53/-1]R: **.**.**.***: 57279 [Transmission 0.72]

I just thought this might be of some use to you.

Attachments (1)

pex-limit.patch (7.2 KB) - added by joshe 15 years ago.
Untested patch to limit utorrent and azureus pex messages to 50 peers

Download all attachments as: .zip

Change History (10)

comment:1 Changed 15 years ago by John Clay

  • Component changed from Transmission to libtransmission
  • Description modified (diff)
  • Owner somebody deleted
  • Priority changed from Normal to High

comment:2 Changed 15 years ago by charles

  • Type changed from Bug Report to Defect

comment:3 Changed 15 years ago by charles

  • Milestone changed from Sometime to 0.80
  • Owner set to charles
  • Status changed from new to assigned

This message is sent by PEPeerTransportProtocol.java when we send more than MAX_PEERS_PER_VOLLEY peers in our added or dropped list. PeerExchangerItem?.java:

public static final int MAX_PEERS_PER_VOLLEY = 50;

comment:4 Changed 15 years ago by charles

Looks like the fix would need to be made in makeCommonPex() in peerext.h

Changed 15 years ago by joshe

Untested patch to limit utorrent and azureus pex messages to 50 peers

comment:5 Changed 14 years ago by livings124

  • Milestone changed from 0.80 to 0.81

comment:6 Changed 14 years ago by charles

joshe: there seems to be a bug in this patch. One block reads, in essence, "while( count < PEX_MAX_PEERS ) { doSomething(); count--; }" s.t. the loop will never end... unless I'm reading something wrong...

comment:7 Changed 14 years ago by anonymous

  • Milestone 0.81 deleted

Milestone 0.81 deleted

comment:8 Changed 14 years ago by charles

  • Milestone set to 0.90

comment:9 Changed 14 years ago by charles

  • Resolution set to invalid
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.