Opened 11 years ago

Closed 11 years ago

#2507 closed Bug (wontfix)

Torrents downloading with same paths issue no warning

Reported by: kip Owned by:
Priority: Low Milestone: None Set
Component: Transmission Version: 1.75
Severity: Minor Keywords: path, overwrite, corrupt, corruption, multiple
Cc:

Description

When downloading more than one torrent that happens to share the same download path, Transmission should issue a warning (or perhaps better, an error) when trying to add the second torrent that it conflicts with a previous one. e.g.

Torrent1 downloads to the following, but contains a subdirectory called "subs": /home/me/Downloads/

Torrent2 downloads to the following, and also contains a subdirectory called "subs": /home/me/Downloads/

Data corruption can occur. If the second torrent is requested for deletion, but the first left alone, both are deleted.

A simple solution would be to consider something like an stl::set which contains a list of all files and paths for every active torrent. When a new torrent is added for downloading or seeding, the set is checked for a hit and, if necessary, issue a warning to the user.

Kip

Attachments (1)

Kip.diff (4.7 KB) - added by kip 11 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 years ago by charles

This issue is reported maybe once a year, if that often. IMO it's better if Transmission doesn't try to nanny users over fringe cases like this.

Changed 11 years ago by kip

comment:2 Changed 11 years ago by kip

I disagree. I think most people who encounter this issue just don't have the time / patience / knowledge to report it to the tracker.

I've started a patch, but lack the knowledge of the architecture fully. I had some issues with getting the library to communicate with tr_torrentContentConflict() and some signal handling with emission via tr_core_errsig( core, TR_PARSE_CONTENT_CONFLICT, filename ).

This should be a good starting point for someone who can finish this who has more knowledge of the architecture. Hope this helps.

Kip

comment:3 Changed 11 years ago by charles

  • Type changed from Defect to Bug

comment:4 Changed 11 years ago by charles

  • Resolution set to invalid
  • Status changed from new to closed

I appreciate the patch, but I really don't think this feature is worth it.

comment:5 Changed 11 years ago by silverballer47

  • Priority changed from Normal to High
  • Resolution invalid deleted
  • Status changed from closed to reopened

Really? I beg to differ.

This exact problem happened to me not three days ago. I was downloading two sets of files with exactly the same folder names, even though the content was different. I ended up losing both sets of files and had to re-download, manually change one of the folder names, and download the second one.

Sure, maybe it's not WORTH it for most people, but even if one person (such as myself) were to benefit from this, I say it's important.

Please consider revisiting this ticket. Thanks!

comment:6 Changed 11 years ago by charles

  • Priority changed from High to Low
  • Resolution set to invalid
  • Status changed from reopened to closed

I sympathise with your situation, but you need to understand that this ticket is not a high priority just because it affects you. This is still an issue that only shows up once or twice a year.

The Transmission team does not have infinite free time on its hands. Your saying that this change may only benefit one person only reinforces my decision to close this ticket.

comment:7 Changed 11 years ago by silverballer47

  • Resolution invalid deleted
  • Status changed from closed to reopened

Yes, sorry about setting it to high. It's not mission critical, I realize that. I didn't realize Trac sets things to high by default...

The Transmission team doesn't have infinite free time, nor is this the most important bug to fix first. Just acknowledging that you can get around to it at some point in the near future is good enough. I don't need this fixed tomorrow, nor do I have the skills to fix the caveats Kip was talking about. If I did, I would talk less and code more.

Perhaps even a pointer for fixing the couple of points Kip raised above...even that is a start for him or someone else to submit the "correct" patch.

Transmission is a great application. Making it as flawless as possible would be a great achievement for you, I'm sure. When you have raised interest from people like Kip who are willing to help given a bit of direction, it should make your job much easier and not tax the resources of the Transmission team as much.

Just my two cents. At the end of the day it's up to y'all; I am fully aware of that.

comment:8 Changed 11 years ago by charles

  • Resolution set to invalid
  • Status changed from reopened to closed

Again I appreciate your opinion but I just don't think this happens often enough to worry about.

comment:9 Changed 11 years ago by charles

  • Resolution invalid deleted
  • Status changed from closed to reopened

comment:10 Changed 11 years ago by charles

  • Resolution set to wontfix
  • Severity changed from Normal to Minor
  • Status changed from reopened to closed

comment:11 Changed 11 years ago by alpha

  • Resolution wontfix deleted
  • Status changed from closed to reopened

comment:12 Changed 11 years ago by charles

  • Resolution set to wontfix
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.