Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2508 closed Bug (fixed)

atom->port never updated

Reported by: jch Owned by: charles
Priority: Normal Milestone: 1.80
Component: libtransmission Version: 1.75
Severity: Normal Keywords:
Cc:

Description

In parseLtepHandshake, when we get a p entry, we update msgs->port. However, at that point the atom has already been created, and has the incoming connection's port.

Shouldn't we be updating the atom's port?

--Juliusz

Attachments (1)

2508.diff (10.0 KB) - added by charles 12 years ago.
jch, how does this look to you?

Download all attachments as: .zip

Change History (8)

comment:1 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.80
  • Owner set to charles
  • Status changed from new to assigned

comment:2 Changed 12 years ago by charles

actually I'm not sure it makes sense to have both a msgs.port and atom.port field. probably we should get rid of the former altogether.

Changed 12 years ago by charles

jch, how does this look to you?

comment:3 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

patch applied to trunk for 1.80 by r9381

comment:4 Changed 12 years ago by charles

  • Resolution fixed deleted
  • Status changed from closed to reopened

No, I seem to have introduced a bug into the patch. Hooray!

Reopening the ticket. r9381 has been reverted in r9383

comment:5 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Summary changed from atom->port never updated? to atom->port never updated

Fixed in trunk for 1.80 by r9434

comment:6 Changed 12 years ago by charles

charles * r9784 libtransmission/ (peer-mgr.h peer-msgs.c resume.c): (trunk libT) #2508 "atom->port never updated" -- (1) fix r9434 bug that used the wrong byte ordering scheme for port numbers. This is why most of the .resume file's peers are worthless in betas 1 and 2. :( (2) in the resume file, change the dictionary key for peers so that the worthless peers won't be reloaded on startup in beta 3.

comment:7 Changed 12 years ago by charles

  • Component changed from Transmission to libtransmission
Note: See TracTickets for help on using tickets.