Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2534 closed Bug (fixed)

if port forwarding is disabled, tr_sessionClose() closes a random file descriptor

Reported by: charles Owned by: charles
Priority: Normal Milestone: 1.77
Component: Transmission Version: 1.76
Severity: Minor Keywords:
Cc:

Description

Reported by Sergey Babitch @ http://forum.transmissionbt.com/viewtopic.php?p=41557&sid=85f1efd7d9e21563d2f4135db0f89c74#p41557

His proposed fix:

ansmission-1.74/libtransmission/natpmp.c    Tue Oct 20 13:02:46 2009 +0300
+++ b/userapps/opensource/transmission-1.74/libtransmission/natpmp.c    Sun Oct 25 23:51:19 2009 +0200
@@ -89,7 +89,7 @@
{
     if( nat )
     {
-        closenatpmp( &nat->natpmp );
+        if (nat->state != TR_NATPMP_DISCOVER) closenatpmp (&nat->natpmp);
         tr_free( nat );
     }
}}}}

Change History (5)

comment:1 Changed 12 years ago by charles

  • Owner set to charles
  • Status changed from new to assigned

fixed in trunk for 1.80 by r9418

comment:2 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:3 Changed 12 years ago by charles

  • Severity changed from Normal to Minor

comment:4 Changed 12 years ago by charles

backported to 1.7x branch in r9870.

comment:5 Changed 12 years ago by charles

  • Keywords backport-1.7x removed
  • Milestone changed from 1.80 to 1.77
Note: See TracTickets for help on using tickets.