Bugs discoveres by scan

[cluthi81]

I asked for a ​scan (automated finding of bugs) of Transmission and it found indeed some errors in the code. They should be pretty easy to fix. This scan has been performed on Transmission 0.72, but the bugs are still present in the trunk. I have asked for a scan on trunk but that's not yet possible.

---

1. peeraz.h:396

   if( NULL == sub && TYPE_LIST != sub->type )
   

I guess it should read

if( NULL != sub && TYPE_LIST != sub->type )

---

2. metainfo.c:351

   return TR_EINVALID;
   

without a

free( list );

introduces a leak on list.

---

3. tracker.c:1023

   return 1;
   

without a

tr_trackerClose( tc );

introduces a leak on tc. Maybe we should just get rid of the blocking tr_trackerScrape function. It's only used in the cli and it seems to me that the new tr_trackerPulse function does the job already. transmissioncli should be updated to reflect this change.

---

4. upnp.c:1005

   *len = ( NULL == body ? 0 : hlen - ( *body - headers ) );
   

I guess it should read

*len = ( NULL == *body ? 0 : hlen - ( *body - headers ) );

[charles]

This is very helpful -- thanks for running the check!

[charles]

Fixed in r2358

[anonymous]

Milestone 0.80 deleted