Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#255 closed Bug (fixed)

Bugs discoveres by scan

Reported by: cluthi81 Owned by:
Priority: High Milestone:
Component: libtransmission Version: 0.80
Severity: Trivial Keywords: bugs
Cc:

Description

I asked for a scan (automated finding of bugs) of Transmission and it found indeed some errors in the code. They should be pretty easy to fix. This scan has been performed on Transmission 0.72, but the bugs are still present in the trunk. I have asked for a scan on trunk but that's not yet possible.


  1. peeraz.h:396
    if( NULL == sub && TYPE_LIST != sub->type )
    

I guess it should read

if( NULL != sub && TYPE_LIST != sub->type )

  1. metainfo.c:351
    return TR_EINVALID;
    

without a

free( list );

introduces a leak on list.


  1. tracker.c:1023
    return 1;
    

without a

tr_trackerClose( tc );

introduces a leak on tc. Maybe we should just get rid of the blocking tr_trackerScrape function. It's only used in the cli and it seems to me that the new tr_trackerPulse function does the job already. transmissioncli should be updated to reflect this change.


  1. upnp.c:1005
    *len = ( NULL == body ? 0 : hlen - ( *body - headers ) );
    

I guess it should read

*len = ( NULL == *body ? 0 : hlen - ( *body - headers ) );

Change History (3)

comment:1 Changed 12 years ago by charles

This is very helpful -- thanks for running the check!

comment:2 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r2358

comment:3 Changed 12 years ago by anonymous

  • Milestone 0.80 deleted

Milestone 0.80 deleted

Note: See TracTickets for help on using tickets.