Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#2564 closed Enhancement (fixed)

Confirm on torrent remove

Reported by: and_hom Owned by: Longinus00
Priority: Low Milestone: 2.00
Component: Qt Client Version: 1.76
Severity: Trivial Keywords:
Cc: and.hom@…

Description

I think, it will be useful to add confirm dialog on "Remove" button. This is a world practice to confirm irreversible operations.

For example, I want to press "Downloading" button, but accidentally press "Remove". So I should to find removed torrent file and add it again.

Attachments (1)

qt_removeDialog.patch (4.3 KB) - added by Longinus00 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by Longinus00

comment:1 Changed 8 years ago by Longinus00

I've added a patch but it doesn't copy the gtk client's remove dialog exactly. It has the following 4 major differences:

  1. Show the number of torrents selected for removal/deletion when n > 1.
  2. A default message which is similar to the mac/web client's for "boring" torrents.
  3. Use a question icon and not a warning icon as that follows the QT interface guidelines better.
  4. Always show a remove dialog for any torrent.

There is a weird hack to force the QMessageBox to be a certain width as it appears to ignore minimumWidth. If somebody knows of a better way to do this then I'm all ears.

Last edited 8 years ago by Longinus00 (previous) (diff)

comment:2 Changed 8 years ago by charles

Longinus00: what happens if someone is running the Qt client as a local session, and connects to it with (say) the web client or transmission-remote, and removes torrents from there? Will this still pop up a confirmation dialog for that?

comment:3 Changed 8 years ago by charles

  • Milestone changed from None Set to 2.00

comment:4 Changed 8 years ago by Longinus00

Okay, so not every torrent, just any time ui.action_Remove or ui.action_Delete get triggered.

What did you think about the other changes?

Last edited 8 years ago by Longinus00 (previous) (diff)

comment:5 Changed 8 years ago by charles

  • Owner changed from charles to Longinus00

comment:6 Changed 8 years ago by charles

  • Resolution set to fixed
  • Status changed from new to closed

comment:7 Changed 8 years ago by charles

patch committed to trunk in r10515.

I like all the other changes with the possible exception of showing the list of torrents when there's more than one. If you're deleting a long list of torrents that could get cumbersome...

Note: See TracTickets for help on using tickets.