Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2651 closed Bug (fixed)

missing errmsg in RPC torrentSet

Reported by: Elbandi Owned by: charles
Priority: Normal Milestone: 1.77
Component: libtransmission Version: 1.60
Severity: Normal Keywords:
Cc:

Description

You set the errmsg to setFilePriorities calls in torrentSet. But forgot use the same in setFileDLs calls:

        if( tr_bencDictFindList( args_in, "files-unwanted", &files ) )
            setFileDLs( tor, FALSE, files );
        if( tr_bencDictFindList( args_in, "files-wanted", &files ) )
            setFileDLs( tor, TRUE, files );

to:

        if( !errmsg && tr_bencDictFindList( args_in, "files-unwanted", &files ) )
            errmsg = setFileDLs( tor, FALSE, files );
        if( !errmsg && tr_bencDictFindList( args_in, "files-wanted", &files ) )
            errmsg = setFileDLs( tor, TRUE, files );

Right?

Change History (4)

comment:1 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.80
  • Version changed from 1.76+ to 1.60

Quite right. Thanks for finding this and for submitting a patch!

comment:2 Changed 12 years ago by charles

  • Status changed from new to assigned

r9687 libtransmission/rpcimpl.c: (trunk libT) #2651: "missing errmsg in RPC torrentSet" -- reported & patched by elbandi

comment:3 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:4 Changed 12 years ago by charles

  • Milestone changed from 1.80 to 1.77

backported to the 1.7x branch for 1.77 in r9879

Note: See TracTickets for help on using tickets.