Opened 13 years ago

Closed 13 years ago

#2774 closed Enhancement (fixed)

Support stats display feature in the web client

Reported by: User294 Owned by: Longinus00
Priority: Normal Milestone: 1.92
Component: Web Client Version: 1.76
Severity: Minor Keywords: patch-needed
Cc:

Description

It could be a good idea to add transfer stats to web UI.
For example GTK+ client allows to view session stats or total stats or ratios in status bar. Web client can do something like this as well. As for me it could be interesting to view transfer stats. Furthermore, when running on a seedbox with limited monthly transfer it could be useful to understand how much bandwidth have been used, etc.

Attachments (1)

webuiStats.patch​ (9.3 KB) - added by Longinus00 13 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 13 years ago by charles

  • Component changed from Transmission to Web Client
  • Owner set to kjg
  • Summary changed from Idea: add option to view session and total transfer stats to web UI. to Support stats display feature in the web client
  • Type changed from Bug to Enhancement
  • Version changed from 1.76+ to 1.76

comment:2 Changed 13 years ago by kjg

  • Keywords patch-needed added

Changed 13 years ago by Longinus00

comment:3 Changed 13 years ago by Longinus00

It would be great if somebody could test this patch on browsers besides firefox and epiphany.

comment:4 Changed 13 years ago by charles

  • Milestone changed from None Set to 2.00
  • Owner changed from kjg to charles
  • Status changed from new to assigned

Looks very nice on Chrome

comment:5 Changed 13 years ago by charles

Longinus00: let me know when you're ready for it to go into trunk

comment:6 Changed 13 years ago by Longinus00

Charles: In IRC benaroia and Balrog verified the patch in the following browsers

  • camino
  • safari 4
  • opera 10.50 windows/mac
  • firefox mac
  • ie 7

Based on their results I think the patch is ready.

comment:7 Changed 13 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

Committed to trunk for 1.92 by r10353

comment:8 Changed 13 years ago by charles

  • Milestone changed from 2.00 to 1.92
  • Resolution fixed deleted
  • Status changed from closed to reopened

Committed to trunk for 1.92 by r10353

That should read "Committed to trunk for 2.00 by r10353"

However I don't see any reason to not put this into 1.92.

comment:9 Changed 13 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

Committed to 1.9x/ for 1.92 by r10354

comment:10 Changed 13 years ago by charles

  • Resolution fixed deleted
  • Status changed from closed to reopened

reopened for attribution

comment:11 Changed 13 years ago by charles

  • Owner changed from charles to Longinus00
  • Status changed from reopened to new

comment:12 Changed 13 years ago by charles

  • Resolution set to fixed
  • Status changed from new to closed

comment:13 Changed 13 years ago by Longinus00

  • Resolution fixed deleted
  • Status changed from closed to reopened

Sigh, I just realized that the dialog might sometimes be too narrow depending on your settings/time and might overflow some text.

I recommend changing the width in common.cs to something like 255. 

@@ -895,7 +895,7 @@
 }
 
 div#stats_container div.dialog_window {
-       width: 255px;
+       width: 230px;
        padding: 0 15px;
 }

comment:14 Changed 13 years ago by charles

Longinus00: is that a reversed diff? its +es and -es are the reverse of your English summary.

Also do you know of any lightweight javascript widget set that we could use to get better layout support for new pieces of code w/o having to start the client over from scratch?

comment:15 Changed 13 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

width patched in trunk for 2.00 by r10367

Note: See TracTickets for help on using tickets.