Opened 12 years ago

Closed 12 years ago

#2796 closed Bug (fixed)

non-GUI compilation issues on Mac OS X 10.4

Reported by: aaro Owned by: charles
Priority: Normal Milestone: 1.90
Component: Transmission Version: 1.81
Severity: Normal Keywords:
Cc:

Description

It should be possible to compile the daemon version with Mac OS X 10.4.

Two patches are attached to fix this.

1) ./configure fails if it cannot find 10.5 SDK. While I understand that the GUI part may have some dependencies to the latest OS versions, I don't think this check is needed unless --enable-mac option is set. So I moved it further. The patch also adds -DMACOSX to CFLAGS on Darwin (which is needed to compile miniupnp).

2) The second patch is a minor fix for miniupnp, the which command does not return an error (at least not on Tiger)  - this fix is already included in the upstream version.

Attachments (3)

01-configure.patch (1.3 KB) - added by aaro 12 years ago.
02-updateminiupnpcstrings.sh.patch (648 bytes) - added by aaro 12 years ago.
01-configure.ac.patch (1.4 KB) - added by aaro 12 years ago.
a patch against configure.ac

Download all attachments as: .zip

Change History (11)

Changed 12 years ago by aaro

Changed 12 years ago by aaro

comment:1 Changed 12 years ago by livings124

The change to miniupnp should be directed upstream to the miniupnp developer.

comment:2 Changed 12 years ago by aaro

The miniupnp change has been already included in the latest upstream version. (It's included here just for reference, in case someone wants to try these patches with 1.81.)

comment:3 Changed 12 years ago by livings124

  • Milestone changed from None Set to 1.90

comment:4 Changed 12 years ago by charles

  • Keywords incomplete added
  • Milestone changed from 1.90 to Sometime

aaro: I can't use that configure patch -- configure is a script automatically generated from configure.ac by the autoconf tool. If you could make a 01-configure.ac.patch I'd be happy to use it.

comment:5 Changed 12 years ago by charles

(a note on that previous change -- this ticket is still fine for 1.90 pending the revised patch)

Changed 12 years ago by aaro

a patch against configure.ac

comment:6 Changed 12 years ago by aaro

A new patch against configure.ac added.

comment:7 Changed 12 years ago by charles

  • Keywords incomplete removed
  • Milestone changed from Sometime to 1.90
  • Owner set to charles
  • Status changed from new to assigned

thanks aaro!

Patches applied to trunk for 1.90 by r10046

comment:8 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.