Snow Leopard Expose Bug -- Fix Included

[bdkjones]

Transmission's performance in Expose on OS 10.6 is spotty. Invoke Expose, then move the cursor over the Transmission window. You'll notice it "jumps" from blue box to no blue box until you move the cursor again.

The bug lies in 'DragOverlayWindow?.m' in the -initForWindow: method. That method currently looks like this:

• (id) initWithLib: (tr_session *) lib forWindow: (NSWindow *) window {

if ((self = ([super initWithContentRect: NSZeroRect styleMask: NSBorderlessWindowMask backing: NSBackingStoreBuffered defer: NO])))

[...]

The fix is to replace the "NSZeroRect" with the frame of the window that's passed to the -initWithLib:forWindow: method. As such, the fix looks like this:

• (id) initWithLib: (tr_session *) lib forWindow: (NSWindow *) window {

if ((self = ([super initWithContentRect: [window frame] styleMask: NSBorderlessWindowMask backing: NSBackingStoreBuffered defer: NO])))

[...]

I have tested this approach in my own application, which uses the same overlay drawing code as Transmission. I can verify that it produces reliable, standard behavior in Expose on 10.6 and fixes the problem I mentioned at the beginning of the ticket.

[livings124]

I can't replicate this issue. Do you see this in r10054?

[livings124]

Please reopen with more info.