Opened 12 years ago

Closed 12 years ago

#2844 closed Enhancement (fixed)

Add option to disable ".part" suffix for incomplete files

Reported by: charles Owned by: charles
Priority: Normal Milestone: 1.90
Component: Transmission Version: 1.83
Severity: Normal Keywords:
Cc:

Description

This has apparently caused lots of Mac users frustration because they can't open partial files in the appropriate media player.

Change History (7)

comment:1 Changed 12 years ago by charles

  • Owner set to charles
  • Status changed from new to assigned

comment:2 Changed 12 years ago by charles

Added to GTK+ and Qt clients, and to rpc spec, in trunk for 1.90 by r10065

comment:3 Changed 12 years ago by tiennou

If I were you, I wouldn't worry too much about Mac users failing to preview .part files. Movie files can be read by opening the reader app first, and dropping the *.part file on it (I'm doing this with VLC atm). It's a rather complicated topic, see http://db.tidbits.com/article/10537 for a little insight, but right now it's broken because Apple *cleverly* decided to silently drop Creator Codes from Snow Leopard (a leftover from OS 9), which means the typing system will resort to the extension to display QuickLook? previews. I'm investigating whether this can be fixed by tweaking T's Info.plist, but this *will* defeat the whole purpose of preventing modifications of files currently being downloaded, which IIRC was the whole point of adding ".part" in the first place...

comment:4 Changed 12 years ago by howl

Mmm, for linux this is not necesary even if you remove completely the extension video-audio files are completely recognized by their magic numbers. Anyway could be some type of files that could need the extension but I don't know any that is not for example code like .c .cpp that are usually small.

comment:5 Changed 12 years ago by nriley

VLC is the *only* one of the common Mac OS X video players that allows you to open a .part file, and even then you have to force it to open it and the icon is wrong. If anything, the Mac version of Transmissino should use file types instead. From Finder.h:

/* Use a filetype in this range to indicate that a file is temporarily busy */
/* (while it is being downloaded or installed, for example).  This prevents */
/* Finder 8.5 and later from trying to change the item's attributes before it */
/* is fully created. -- If you provide a series of 'BNDL' icons for your creator */
/* and some of these filetypes, you can achieve limited icon animation while */
/* the file creation progresses. */
enum {
  kFirstMagicBusyFiletype       = 'bzy ',
  kLastMagicBusyFiletype        = 'bzy?'
};

Yes, it's old, but I just checked and both the 10.5 and 10.6 Finder still support the use of this file type. While you can't double-click a "busy" file to open it, you can still drag and drop it onto an application, which I think is much better behavior than the current .part behavior.

comment:6 Changed 12 years ago by livings124

r10119 for Mac

comment:7 Changed 12 years ago by livings124

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.