Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2872 closed Enhancement (fixed)

Show ratio torrent is stopped in remote

Reported by: Longinus00 Owned by: charles
Priority: Normal Milestone: 1.90
Component: Daemon Version: 1.83
Severity: Normal Keywords:
Cc:

Description

I don't know how to check the ratio a torrent stops at with remote so I figured it should be added to the info command.

As an aside, is there any particular reason why the ratio is calculated in the remote and not pulled from transmission via the "uploadRatio" key?

Attachments (3)

stopRatio.diff (989 bytes) - added by Longinus00 12 years ago.
stopRatio2.diff (4.1 KB) - added by Longinus00 12 years ago.
stopRatio3.diff (2.1 KB) - added by Longinus00 12 years ago.

Download all attachments as: .zip

Change History (10)

Changed 12 years ago by Longinus00

comment:1 Changed 12 years ago by charles

  • Component changed from Transmission to Daemon
  • Milestone changed from 1.90 to None Set
  • Owner set to charles
  • Status changed from new to assigned
  • Type changed from Bug to Enhancement

<stock message> Please don't set milestones unless you've already talked it over with the developers. Trac is mostly to blame for this; it doesn't seem to offer fine-grained control over who can set what ticket attributes. Still, I'm sure you can see that setting the developers' deadlines for them is not how things should be done. ;) </stock message>

comment:2 Changed 12 years ago by charles

Longinus00: this raw number isn't very useful without the context of the seed mode -- you can't even whether a maximum seed mode is enabled. Can this patch be updated to be more informative?

comment:3 Changed 12 years ago by Longinus00

Sorry about the milestone! Is this what you mean by maximum seed mode being enabled?

Changed 12 years ago by Longinus00

comment:4 Changed 12 years ago by livings124

Why do you add and look for TR_PREFS_KEY_SEED_RATIO_* (with the corresponding string not even in the same style as all the others) instead of using TR_PREFS_KEY_RATIO_LIMIT. This code works for you?

comment:5 Changed 12 years ago by charles

  • Milestone changed from None Set to 1.90
  • Resolution set to fixed
  • Status changed from assigned to closed

Looks good to me. Thanks for the patch.

Committed to trunk for 1.90 by r10128.

I removed the two keys from transmission.h because this is one of those instances where the settings.json keys are maddeningly different from the RPC spec's keys. Someday there will have o be a great renaming to resolve this, but that's not a high priority, and in the meantime it's probably best to not confuse the issue in transmission.h. :)

comment:6 Changed 12 years ago by Longinus00

Yea, I was not exactly sure why it relied on defines for the session information but used the hard-coded values for pulling other the data. It's too bad it doesn't seem possible to pull the global seed ratio if it's being used without another rpc call.

comment:7 Changed 12 years ago by Longinus00

Really minor, but I realized that the upload ratio limit would probably be better off in the "LIMITS" section of the output.

Changed 12 years ago by Longinus00

Note: See TracTickets for help on using tickets.