Opened 12 years ago

Closed 12 years ago

#2894 closed Enhancement (fixed)

tr_torrentGetFileDL() and tr_torrentGetFilePriority() should go away

Reported by: charles Owned by: charles
Priority: Normal Milestone: 1.90
Component: Transmission Version: 1.83
Severity: Minor Keywords:


These were intended as convenience functions to avoid having to drill too deeply into tr_info by hand, but they require a mutex lock, add some general purpose assertions, and are called from inside loops. The only client code that uses it is in the Mac and GTK+ GUIs' file list code.

These two pieces of code should access the tr_info.files[i].xxx fields directly and avoid the unnecessary overhead.

When that's done, tr_torrentGetFileDL() and tr_torrentGetFilePriority() will be unused and can be removed.

Change History (4)

comment:1 Changed 12 years ago by charles

  • Owner set to charles
  • Status changed from new to assigned

Implemented for the GTK+ client for 1.90 in r10172

comment:2 Changed 12 years ago by charles

r10173: finished removing them from the GTK+ client in trunk for 1.90

comment:3 Changed 12 years ago by charles

r10174: removed it from macosx and libtransmission

comment:4 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.