Opened 13 years ago
Closed 13 years ago
#2906 closed Enhancement (fixed)
remove unused code: Torrent.requests array is never sorted by time
Reported by: | sadface | Owned by: | sadface |
---|---|---|---|
Priority: | Normal | Milestone: | 1.92 |
Component: | libtransmission | Version: | 1.83 |
Severity: | Minor | Keywords: | |
Cc: |
Description
So I propose to clean up some lines of code.
Attachments (1)
Change History (8)
Changed 13 years ago by sadface
comment:1 Changed 13 years ago by charles
- Milestone changed from None Set to Sometime
- Status changed from new to assigned
comment:2 Changed 13 years ago by charles
- Milestone changed from Sometime to 1.91
- Severity changed from Normal to Minor
comment:3 Changed 13 years ago by charles
- Milestone changed from 1.91 to Sometime
Bumping out of 1.91. On a rational level I see nothing wrong with this code, but it's in a sensitive part of libtransmission and has zero operation impact, so I'm going to wait until we have a longer interval between releases to let it burn in...
comment:4 Changed 13 years ago by charles
- Milestone changed from Sometime to 1.92
- Resolution set to fixed
- Status changed from assigned to closed
- Summary changed from Torrent.requests array is never sorted by time to remove unused code: Torrent.requests array is never sorted by time
Fixed in trunk for 1.92 by r10270.
comment:5 Changed 13 years ago by charles
- Resolution fixed deleted
- Status changed from closed to reopened
reopened for attribution
comment:6 Changed 13 years ago by charles
- Owner changed from charles to sadface
- Status changed from reopened to new
comment:7 Changed 13 years ago by charles
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
This patch looks great and we should use it. After the 1.90 bugfix freeze is released, this should be committed.