Opened 12 years ago

Closed 12 years ago

#2914 closed Enhancement (invalid)

Add an option allowing torrents reached their seed ratio to be automatically moved to a different location

Reported by: er13 Owned by:
Priority: Normal Milestone: None Set
Component: Transmission Version:
Severity: Normal Keywords:
Cc:

Description

There are some usage scenarios this feature might be useful in. Possible implementation attached.

Attachments (2)

finish_dir_r10222.patch (14.6 KB) - added by er13 12 years ago.
finish_dir_r10301.patch (14.5 KB) - added by er13 12 years ago.

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by er13

Changed 12 years ago by er13

comment:1 Changed 12 years ago by er13

@Charles: would you please make a short comment on the patch, i.e. interested, not interested, not interested because of bad quality, not interested because of no added value, etc. Thanks!

comment:2 Changed 12 years ago by charles

  • Resolution set to invalid
  • Status changed from new to closed

Hi er13,

Sorry for not posting sooner. I'm torn on what to do with this patch.

On the one hand, I feel like this patch adds extra complexity for a feature that not many people would use. We already support incomplete and complete directories -- expanding that to three directories for incomplete, seeding, and finished, seems convoluted and like overkill, to me.

On the other hand the code is good, and you've got a good track record of submitting patches to Transmission. That's a factor because people whose patches are turned down often take it personally and don't contribute more patches...

Still, I don't think this feature is something many people would use, and it definitely creates more permutations to test and maintain when moving files around. I'm going to turn down this patch, but appreciate your work and hope you contribute more patches in the future. :)

Note: See TracTickets for help on using tickets.