Opened 12 years ago

Closed 12 years ago

#294 closed Bug (invalid)

Too many upload slots

Reported by: Eliteforce Owned by:
Priority: Normal Milestone:
Component: libtransmission Version: 0.80
Severity: Normal Keywords: upload slots
Cc:

Description

Transmission 0.80
10 kb/s upload limit
-> 8-12 upload slots each with very slow speed (see screenshot)

the upload slots should be limited to about 3 with this upload speed limit (even up to 22kb/s upload, see utorrent speed guide)

funny thing is, that if i set the download limit to 10 kb/s the UL slots decrease slowly to 4. looks like the slots calculation is based on the download speed instead of the upload speed.

Change History (5)

comment:1 Changed 12 years ago by jah

slots are determined by upload speed. the code is here: (choking.c line 58)

void tr_chokingSetLimit( tr_choking_t * c, int limit )
{
    tr_lockLock( c->lock );
    if( limit < 0 )
        c->slots = 4242;
    else
        /* Reckon a number of slots from the upload limit. There is no
           official right way to do this, the formula below e.g. gives:
            10  KB/s -> 4  * 2.50 KB/s
            20  KB/s -> 6  * 3.33 KB/s
            50  KB/s -> 10 * 5.00 KB/s
            100 KB/s -> 14 * 7.14 KB/s */
        c->slots = lrintf( sqrt( 2 * limit ) );
    tr_lockUnlock( c->lock );
}

comment:2 Changed 12 years ago by charles

  • Component changed from Transmission to libtransmission
  • Owner somebody deleted

comment:3 Changed 12 years ago by livings124

  • Milestone 0.80 deleted
  • Resolution set to fixed
  • Status changed from new to closed

comment:4 Changed 12 years ago by livings124

  • Resolution fixed deleted
  • Status changed from closed to reopened

Closed by mistake.

comment:5 Changed 12 years ago by livings124

  • Resolution set to invalid
  • Status changed from reopened to closed

This will be obsolete in .9 anyway.

Note: See TracTickets for help on using tickets.