Opened 12 years ago

Closed 12 years ago

#2948 closed Bug (fixed)

When a torrent becomes complete or stopped, 1.90 double-announces

Reported by: charles Owned by: charles
Priority: Normal Milestone: 1.91
Component: libtransmission Version: 1.90
Severity: Normal Keywords:
Cc:

Description

This is an implementation error in 1.90's new announce queueing code. After starting a torrent, we add a periodic update to the tracker's queue and the announce time to now + $tracker-announce-interval. If for example a torrent becomes complete, we append an "&event=completed" to the announce queue and set the announce time to now, causing the periodic update and completed (or stopped, etc) announcements to be sent back-to-back.

The queue approach may have been a bad idea -- a state machine would probably be a cleaner solution. However, that's beyond the scope of a bugfix release. For 1.91 what we should do is discard the periodic announces from the queue iff a non-periodic event follows it.

Change History (2)

comment:1 Changed 12 years ago by charles

  • Status changed from new to assigned

comment:2 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in trunk for 1.91 by r10238

Note: See TracTickets for help on using tickets.