Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2988 closed Enhancement (invalid)

Make Mac client support upload-slots-per-torrent

Reported by: nifoc Owned by:
Priority: Normal Milestone: None Set
Component: Transmission Version: 1.91
Severity: Normal Keywords:
Cc:

Description

I've made a very very simple patch to add support for upload-slots-per-torrent to the Mac client.

Note: Wehen you set it so (e.g.) 10 slots, Transmission will actually use 11 slots. I don't think that has something to do with my patch (because it's really only two lines of code), so it might be a bug in libtransmission?

Attachments (1)

upload_slots_per_torrent.diff (980 bytes) - added by nifoc 12 years ago.

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by nifoc

comment:1 follow-up: Changed 12 years ago by charles

  • Resolution set to invalid
  • Status changed from new to closed

Thank you for the suggestion, and especially thanks for reading through the code and for making a patch. It's always a good thing to have more prorammers reading through the code.

However, this isn't an officially-supported feature, so it's not going to be in the GUI for the time being. The reason for this is that at some point I'd like to have the code automatically figure out optimum number of upload slots so that a hardcoded value isn't necessary.

Now, if you'd like to make a patch for that... ;)

comment:2 in reply to: ↑ 1 Changed 12 years ago by nifoc

Replying to charles:

I'd like to have the code automatically figure out optimum number of upload slots so that a hardcoded value isn't necessary.

After a quick Google search it seems like figuring this out is rather easy. All of these "speed guides" suggest something like: 1 + (upload speed / 6)

to calculate the number of upload slots. If this is really all you want, I could definitely make a patch for that. I just need to look through the code a bit more. Figuring out where the Mac client does all the settings stuff wasn't that hard ;)

Note: See TracTickets for help on using tickets.