Opened 11 years ago

Closed 11 years ago

#3054 closed Bug (fixed)

Impossible to set sorting direction in the Web UI

Reported by: mjpieters Owned by: Longinus00
Priority: Normal Milestone: 1.93
Component: Web Client Version: 1.92
Severity: Normal Keywords:
Cc:

Description

You can no longer toggle the sorting direction in the web UI. It looks as if processSettingsMenuEvent is called twice for every menu click, thus setting and resetting the direction option.

To reproduce:

  • Select the 'Sort Transfers By' > 'Reverse Sort Order' option

observe that it doesn't change by going to the same menu item again.

If the option was set (read from the cookie) it'll remain set. Select a different sorting option (name, or age, etc) and the Reverse option is reset. Try and set it and you'll observe the same behavior.

A quick test with firebug shows that the processSettingsMenuEvent event handler is called twice. Likely a event cancellation is missing.

Observed in Chrome (5.0.307.11 beta), Safari (4.0.5) and Firefox (3.6).

Change History (9)

comment:1 Changed 11 years ago by InfernoZeus

I've also had the same problem using SRWare Iron 4.0.280.

comment:2 Changed 11 years ago by AVI

I have the same problem in Ubuntu. Until he decided to copy it from the web interface version 1.91

comment:3 Changed 11 years ago by Longinus00

A quick and dirty fix would be to do this

--- web/javascript/transmission.js
+++ web/javascript/transmission.js
@@ -1085,6 +1085,7 @@ Transmission.prototype =
 
                                // The 'reverse sort' option state can be toggled independently of the other options
                                if ($element.is('#reverse_sort_order')) {
+                                       if(!$element.is('#reverse_sort_order.active')) break;
                                        var dir;
                                        if ($element.menuItemIsSelected()) {
                                                $element.deselectMenuItem();

comment:4 Changed 11 years ago by charles

  • Keywords backport-1.9x added
  • Milestone changed from None Set to 2.00
  • Owner changed from kjg to Longinus00

comment:5 Changed 11 years ago by charles

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in trunk for 2.00 by r10429 by Longinus00's patch

comment:6 Changed 11 years ago by charles

  • Keywords backport-1.9x removed
  • Milestone changed from 2.00 to 1.93

backported to 1.9x by r10585

comment:7 Changed 11 years ago by obveron

  • Milestone changed from 1.93 to None Set
  • Resolution fixed deleted
  • Status changed from closed to reopened

This is still not working for me. I upgraded to 1.93 and I still can't reverse sort order in Web UI.

Firefox 3.6.3

comment:8 Changed 11 years ago by rajivbattula

could you be more specific? I just tested with 1.93 and firefox 3.6.3 and the reverse sort order is working correctly in the Web UI.

comment:9 Changed 11 years ago by livings124

  • Milestone changed from None Set to 1.93
  • Resolution set to fixed
  • Status changed from reopened to closed

obveron: empty your cache

Note: See TracTickets for help on using tickets.