Opened 8 years ago

Closed 8 years ago

#3094 closed Enhancement (fixed)

Show ratio goal for partial seeds

Reported by: Longinus00 Owned by: Longinus00
Priority: Low Milestone: 2.00
Component: Transmission Version: 1.92
Severity: Minor Keywords:
Cc:

Description

I don't know why this is hidden.

Attachments (1)

partialSeedRatio.patch (3.7 KB) - added by Longinus00 8 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by Longinus00

comment:1 Changed 8 years ago by Longinus00

This also lets partial seeds show the seed time remaining. (in the QT client)

Last edited 8 years ago by Longinus00 (previous) (diff)

comment:2 Changed 8 years ago by Longinus00

Elbandi and I talked about using a ternary operator instead of string operations but I'm unsure if that's such a good decision translation wise. Let me know if you want to use that instead and I'll change the patch.

comment:3 Changed 8 years ago by charles

  • Type changed from Bug to Enhancement

comment:4 Changed 8 years ago by charles

Longinus00: does this patch behave similarly to how the Mac client does it?

comment:5 Changed 8 years ago by Longinus00

charles: Judging by the screenshot on the homepage, the mac client uses multicolored progress bars to show the goal relative to how much is currently seeded. Since the gtk and qt clients don't have that feature they rely on textual displays.

comment:6 Changed 8 years ago by charles

  • Milestone changed from None Set to 2.00
  • Owner set to Longinus00

Committed a variation of the patch to trunk for 2.00 by r10433.

The diff between your patch and mine is that mine is more plodding with yet another full block of code to create a full string. I'm told this is preferable because it gives the translators more flexibility.

comment:7 Changed 8 years ago by charles

  • Resolution set to fixed
  • Status changed from new to closed

comment:8 follow-up: Changed 8 years ago by Longinus00

  • Resolution fixed deleted
  • Status changed from closed to reopened

Your code has a bug :)

--- qt/torrent-delegate.cc
+++ qt/torrent-delegate.cc
@@ -93,8 +93,8 @@ TorrentDelegate :: progressString( const Torrent& tor ) const
                   .arg( Utils::sizeToString( tor.sizeWhenDone( ) ) )
                   .arg( tor.percentDone( ) * 100.0, 0, 'f', 2 )
                   .arg( Utils::sizeToString( tor.uploadedEver( ) ) )
-                  .arg( Utils::ratioToString( tor.ratio( ) )
-                  .arg( Utils::ratioToString( seedRatio ) ) );
+                  .arg( Utils::ratioToString( tor.ratio( ) ) )
+                  .arg( Utils::ratioToString( seedRatio ) );
         }
         else
         {

comment:9 in reply to: ↑ 8 Changed 8 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

Replying to Longinus00:

Your code has a bug :)

Well, it wouldn't be the first time. Thanks for the fix. :)

Note: See TracTickets for help on using tickets.