Show ratio goal for partial seeds

[Longinus00]

I don't know why this is hidden.

[Longinus00]

This also lets partial seeds show the seed time remaining. (in the QT client)

[Longinus00]

Elbandi and I talked about using a ternary operator instead of string operations but I'm unsure if that's such a good decision translation wise. Let me know if you want to use that instead and I'll change the patch.

[charles]

Longinus00: does this patch behave similarly to how the Mac client does it?

[Longinus00]

charles: Judging by the screenshot on the homepage, the mac client uses multicolored progress bars to show the goal relative to how much is currently seeded. Since the gtk and qt clients don't have that feature they rely on textual displays.

[charles]

Committed a variation of the patch to trunk for 2.00 by r10433.

The diff between your patch and mine is that mine is more plodding with yet another full block of code to create a full string. I'm told this is preferable because it gives the translators more flexibility.

[Longinus00]

Your code has a bug :)

--- qt/torrent-delegate.cc
+++ qt/torrent-delegate.cc
@@ -93,8 +93,8 @@ TorrentDelegate :: progressString( const Torrent& tor ) const
                   .arg( Utils::sizeToString( tor.sizeWhenDone( ) ) )
                   .arg( tor.percentDone( ) * 100.0, 0, 'f', 2 )
                   .arg( Utils::sizeToString( tor.uploadedEver( ) ) )
-                  .arg( Utils::ratioToString( tor.ratio( ) )
-                  .arg( Utils::ratioToString( seedRatio ) ) );
+                  .arg( Utils::ratioToString( tor.ratio( ) ) )
+                  .arg( Utils::ratioToString( seedRatio ) );
         }
         else
         {

[charles]

Replying to Longinus00:

Your code has a bug :)

Well, it wouldn't be the first time. Thanks for the fix. :)