#3119 closed Bug (fixed)
Showing torrent properties can causes rearranging of torrents if sort != sortByName
Reported by: | Longinus00 | Owned by: | Longinus00 |
---|---|---|---|
Priority: | Normal | Milestone: | 1.93 |
Component: | Qt Client | Version: | 1.92 |
Severity: | Normal | Keywords: | |
Cc: |
Description
Pause two torrents and sort by activity. Display torrent properties and watch as each one gets sent to the bottom of the torrent list.
Attachments (1)
Change History (8)
comment:1 Changed 11 years ago by charles
comment:2 Changed 11 years ago by Longinus00
I guess it is implementation dependent...
comment:3 Changed 11 years ago by charles
Ha! That's disgusting but I like it :)
comment:4 Changed 11 years ago by Longinus00
Line 144: less = a->id() - b->id(); should also be changed to use compare().
Changed 11 years ago by Longinus00
really no subtraction operations, also changed the last comparison to hash strings instead of id as hashstrings will survive a restart
comment:5 Changed 11 years ago by charles
- Keywords backport-1.9x added
- Milestone changed from None Set to 2.00
- Owner changed from charles to Longinus00
Fixed in trunk for 2.00 by r10459 with Longinus00's patch
comment:6 Changed 11 years ago by charles
- Resolution set to fixed
- Status changed from new to closed
comment:7 Changed 11 years ago by charles
- Keywords backport-1.9x removed
- Milestone changed from 2.00 to 1.93
backported to 1.9x by r10586
Note: See
TracTickets for help on using
tickets.
I'm not sure about the safety of int i = uint64_t a - uint64_t b. What happens if b > a?