Opened 12 years ago

Closed 12 years ago

#3142 closed Bug (invalid)

Please don't fsync

Reported by: jch Owned by: charles
Priority: Low Milestone: None Set
Component: libtransmission Version: 1.92
Severity: Minor Keywords:
Cc:

Description

(trunk libT) add an fsync() before closing files

+ fsync( fd );

Charles, I object.

On a modern filesystem, this patch buys you nothing as far as safety goes, while absolutely killing performance.

I object to this patch unless you can explain what issue you're trying to solve.

--Juliusz

Change History (2)

comment:1 Changed 12 years ago by jch

Turns out this was removed by a later commit.

comment:2 Changed 12 years ago by jch

  • Resolution set to invalid
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.