Opened 12 years ago

Closed 12 years ago

#3235 closed Bug (fixed)

Changeset 10293 broke the moving files fron complete to incomplete dir when both dirs have same inode on different devices

Reported by: ndenev Owned by: charles
Priority: Normal Milestone: 2.00
Component: libtransmission Version: 1.92
Severity: Normal Keywords: backport-1.9x
Cc:

Description

Since https://trac.transmissionbt.com/changeset/10293 the moving of completed files form the incomplete dir to the complete dir stopped working. I'm running transmission-daemon-1.93 on FreeBSD 8.1-PRERELASE on ZFS filesystem, which I believe handles/assigns inodes dynamically and this might be the problem.

here is some output from the log file which seems possible cause (same inode numbers): May 26 09:13:28 nas transmission-daemon: path1 inode is 3; path2 inode is 3 (torrent.c:2444)

P.S.: complete and incomplete dirs are different ZFS datasets/filesystems

Change History (2)

comment:1 Changed 12 years ago by charles

  • Keywords backport-1.9x added
  • Milestone changed from None Set to 2.00
  • Status changed from new to assigned
  • Summary changed from Changeset 10293 broke the moving of complete files out of incomplete dir to Changeset 10293 broke the moving files fron complete to incomplete dir when both dirs have same inode on different devices
  • Version changed from 1.93 to 1.92

Fixed in trunk for 2.00 by r10692

Thanks for tracking down which revision broke this, and for looking up the directories' inodes on your machine. That legwork made it pretty easy to understand that the fix was to add a device check to the inode check :)

comment:2 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.