Opened 11 years ago

Closed 11 years ago

#3256 closed Enhancement (fixed)

libtransmission/publish.[ch] should be replaced

Reported by: charles Owned by: charles
Priority: Normal Milestone: 2.10
Component: libtransmission Version: 1.93
Severity: Minor Keywords:
Cc:

Description

tr_publish is a generic observer/observable tool. This is fine; however, we're only using it in a place where there is exactly a 1-1 mapping between observer and observable, and the observable is watched during its entire lifespan. So we can save a little overhead by using simple fields for callback func + client_data pointer in the observable.

Attachments (1)

publish.diff​ (18.7 KB) - added by charles 11 years ago.
patch to replace publish.[ch] with simple callback func + client_data fields

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by charles

patch to replace publish.[ch] with simple callback func + client_data fields

comment:1 Changed 11 years ago by charles

  • Milestone changed from 2.10 to 2.01

comment:2 Changed 11 years ago by charles

  • Milestone changed from 2.01 to 2.10

...nah, this doesn't cross the threshold for a bugfix release

comment:3 Changed 11 years ago by charles

publish.diff committed to trunk for 2.10 by r10800

comment:4 Changed 11 years ago by charles

  • Component changed from Transmission to libtransmission
  • Owner set to charles
  • Status changed from new to assigned

comment:5 Changed 11 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.