Opened 11 years ago

Closed 11 years ago

#3275 closed Bug (fixed)

Seed ratio limit and ratio limit enabled are currently not pulled from a remote session.

Reported by: Longinus00 Owned by: Longinus00
Priority: Normal Milestone: 2.00
Component: Qt Client Version: 1.93
Severity: Normal Keywords:
Cc:

Description


Attachments (1)

qt_fixSessionRatio.patch (565 bytes) - added by Longinus00 11 years ago.

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by Longinus00

comment:1 Changed 11 years ago by Longinus00

  • Milestone changed from None Set to 2.10

comment:2 Changed 11 years ago by Longinus00

  • Summary changed from Seed ratio limit and ratio limit enabled is currently not pulled from a remote session. to Seed ratio limit and ratio limit enabled are currently not pulled from a remote session.

The rpc keys are a mix of camel case and hyphen delimited strings. Of the session arguments, however, only seedRatioLimit and seedRatioLimited are camel cased. Maybe they should be dropped for the pref keys ratio-limit and ratio-limit-enabled?

comment:3 Changed 11 years ago by charles

As you've pointed out there are two parts to this.

For 2.00, let's use your patch as it fixes the bug for now.

As for changing the key names, IMO it's not a good idea to make rpc changes this late in the dev cycle... the third party app authors wouldn't have much time to sync their apps to 2.0. For that half, I agree with your 2.10 milestone.

So you could open a second ticket for the camelCase names if you like, or just leave this one open even after committing the patch.

comment:4 Changed 11 years ago by Longinus00

  • Milestone changed from 2.10 to 2.00
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r10738

Note: See TracTickets for help on using tickets.