Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3372 closed Bug (fixed)

What happened with closing idle peers?

Reported by: sadface Owned by: jordan
Priority: Normal Milestone: 2.22
Component: libtransmission Version: 2.01
Severity: Normal Keywords:
Cc:

Description

Since r10500 peers tagged as TR_CAN_CLOSE are not disconnected, but related code remains in libtransmission: https://trac.transmissionbt.com/browser/trunk/libtransmission/peer-mgr.c#L2813

Change History (6)

comment:1 Changed 11 years ago by charles

I'm not sure what to do about this. How important is it for Transmission to keep churning through peers? It sounds like a good idea, but in practice it doesn't seem to have much effect, and definitely keeps load high on poor routers. It might be better overall to be more lenient to peers.

Do you have any opinion on what the Right Thing to do here is?

comment:2 Changed 11 years ago by sadface

Sorry, I think I can't help you.

comment:3 Changed 11 years ago by jordan

  • Milestone changed from None Set to Sometime
  • Owner changed from charles to jordan
  • Status changed from new to assigned

comment:4 Changed 11 years ago by jordan

  • Milestone changed from Sometime to 2.30

comment:5 Changed 11 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r11982.

comment:6 Changed 11 years ago by jordan

  • Milestone changed from 2.30 to 2.22

15:13:51 < CIA-60> jordan * r12028 /branches/2.2x/libtransmission/peer-mgr.c: (2.2x) backport r11980, r11981, r11982 for #3372 "What happened with closing idle peers?"

Note: See TracTickets for help on using tickets.