Opened 14 years ago

Closed 14 years ago

#338 closed Enhancement (fixed)

Better GNOME Integration

Reported by: infernux Owned by:
Priority: Normal Milestone: 0.90
Component: GTK+ Client Version: 0.82
Severity: Normal Keywords:
Cc: michael.monreal@…

Description

Transmission/GTK is a very nice client.

There are, however, a few things that can be done differently to better match the standards of the GNOME desktop environment and the Human Interface Guidelines (HIG). I prepared a patch which changes the following:

Main menu:

  • removed/renamed various entries to match the GNOME HIG
  • standard order/names
  • inserts ... where needed
  • replaced "File" by "Torrent" (after all we work with torrent files here and not generic files)
  • replaced start/stop icons with better fitting gtk stock icons

Main toolbar:

  • added "New..." at the right position to match the GNOME HIG
  • added a separator behind "Open..." to form the action group start/pause/remove

Main window:

  • only show vertical scrollbar if needed

Torrent inspector:

  • window renamed to "Details"
  • got rid of the area above the notebook
  • integrated the info provided above the notebook into the window title
  • use tango colors for the parts
  • use tango-style icons for the red/yellow/green dots

Attachments (3)

transmission-gnome.diff (28.4 KB) - added by infernux 14 years ago.
GNOME/HIG Patch #1
transmission-colors.png (17.9 KB) - added by infernux 14 years ago.
Tango colors used (tried to get a close match, uses green for fully received)
transmission-gnome-2.diff (9.6 KB) - added by infernux 14 years ago.
Updated GNOME/HIG Patch

Download all attachments as: .zip

Change History (12)

Changed 14 years ago by infernux

GNOME/HIG Patch #1

comment:1 Changed 14 years ago by infernux

  • Cc michael.monreal@… added
  • Type changed from Bug Report to Enhancement

There are a few more things that would be nice to fix but this is what I have so far...

Changed 14 years ago by infernux

Tango colors used (tried to get a close match, uses green for fully received)

Changed 14 years ago by infernux

Updated GNOME/HIG Patch

comment:2 Changed 14 years ago by infernux

I removed the updated inline pixbuf stuff because I have another patch ready to make full use of GTK icon themes (application & build system) which makes this sort of stuff unnecessary.

The two patches conflict a bit so it would be nice to have this stuff reviewed and committed so that I can patch against this base.

comment:3 Changed 14 years ago by infernux

Perhaps "Properties" would be better for the "Torrent Inspector" window than "Details"?

comment:4 Changed 14 years ago by charles

I like the idea of this in principle, but have some problems with the current patch:

  • although the ellipses are correct in the menu, they look pretty awkward in the toolbar
  • oh, that green is ugly. =)

comment:5 Changed 14 years ago by infernux

Glad you like it in principle. Ok let's discuss the points. What exactly in the toolbar is wrong now? The tooltips? About those colors... well, yeah. I'm not very fond of this myself but mainly I don't think the colors currently used make that much sense (dark=few, light=many/all)

comment:6 Changed 14 years ago by infernux

Do you mean the ellipses in the toolbar with the setting "text below icons", why would the menu have ellipses and the toolbar not? If you have a look at other GNOME apps like EOG or Evince, they also have ellipses in the toolbar (see Open...). I guess this is really how it is meant to be and I don't really see the problem

comment:7 Changed 14 years ago by charles

I've done some more on this ticket and would welcome feedback. Here are the changes made in r3352:

HIG-specific changes from, or inspired by, infernux' patch

  • follow HiG suggestion that dialog titles match the command that opened it. (This was broken in a lot of places)
  • renamed "File" menu as "Torrent" menu
  • renamed "Torrent Inspector" as "Properties" and moved to Torrent menu
  • "Select All" and "Deselect All" accelerators and underscores now match HIG

Other usability changes

  • renamed "Recheck" as "Verify Local Files" for clarity
  • renamed "Update Tracker" as "Ask Tracker for More Peers" for clarity

Not yet used:

  • tango colors in the Properties page (I'm open to this, but the colors in the patch are ugly)
  • icon changes (I'm somewhat open to this, but the fewer extra files we need, the better)
  • grouping new' and open' together (IMO these don't belong together. The HiG suggestion is for opening and creating files, which are both common... but most users will probably /never/ create their own torrent file.)

comment:8 Changed 14 years ago by infernux

Great stuff so far! As for the rest:

  • tango colors: I'll discuss this with the tango crew, but I've seen you already changed the colors a bit?
  • icon changes: relevant changes are already filed as bug 376. But generally, why "the less files, the better"? If an icon is used in different sizes, it has to be provided in different sizes. For standard GNOME, toolbars are 24x24 pixel, but for some accessibility themes (LargePrint?) they are 48x48 and the smaller icons scaled up just look ugly. Same for scaling down icons that are bigger than 16x16 for the menu. Also: it's nice if you can use default icons from GTK or gnome-icon-theme, but if all the required sizes are not available (gtk-info) or the image doesn't match the functionality (lock-screen for "encrypted", ugh, now dialog password, which is a set of keys in SVN gnome-icon-theme) shipping icons should be totally fine. Take a look at bug 376, maintenance of this will be very easy.
  • "new" in the toolbar: well, I totally agree. I know the HIG suggestion but I mostly changed this part because the OSX client also seems to have the icon in the toolbar. But as you noted, the action is probably too uncommon to deserve a toolbar entry ;)

One thing I'm not sure about is the order in the Torrent menu, but thinking about it, this order seems to make sense after all. This ticket can probably be closed now. So, great work and have a look at bug 376.

comment:9 Changed 14 years ago by charles

  • Milestone changed from None Set to 0.90
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.