Opened 14 years ago

Closed 14 years ago

#343 closed Enhancement (fixed)

Tango application icon

Reported by: infernux Owned by:
Priority: Normal Milestone: None Set
Component: GTK+ Client Version: 0.82
Severity: Normal Keywords:
Cc:

Description

In addition to the changes I proposed in ticket 338 (Better GNOME Integration) it would be nice if the GTK client would use proper icon theming as well as icons that make use of the Tango guidelines.

I have both a patch and a tar with new icons and complete build system integration ready to use.

The patch...

  • removes the internal stock theming and inline pixbuf images
  • adds proper GTK theming
  • makes use of the new icons (window title, tray, menu, toolbar, info window)
  • minor tweaks to the about dialog to conform with HIG guildelines (added logo & description)
  • integrates the new gtk/data directory into the build

The tarball...

  • contains new icons & makefiles, to be added as gtk/data
  • new icons:
    • application icon (launcher, window list, tray): done by GNOME/Tango artist Andreas Nilsson
    • info icon (menu, toolbar): also done by Andreas Nilsson, already used in other apps
    • peer status icons: green/red (also yellow is provided) done by myself
    • lock icon: I didn't see this in the GUI yet... what does the current lock icon look like?

Attachments (4)

data.tar.bz2 (31.1 KB) - added by infernux 14 years ago.
Icons
transmission-icons.diff (7.8 KB) - added by infernux 14 years ago.
Patch
data.tar.2.bz2 (42.0 KB) - added by infernux 14 years ago.
Using original project logo as icon
tr_icon.diff (6.1 KB) - added by infernux 14 years ago.
Patch to integrate gtk/data into the build

Download all attachments as: .zip

Change History (13)

Changed 14 years ago by infernux

Icons

comment:1 Changed 14 years ago by infernux

I forgot: the data tarball also includes a .desktop file, which is installed. Another one is provided wich is marked for translation, but this needs proper intltool integration for localization first.

The following files can savely be removed after extracting the tarball in gtk/ and applying tha patch: gtk/dot-icons.h, gtk/img_icon_full.h, gtk/transmission-gtk.desktop, gtk/transmission.png, gtk/lock-icon.h

Any new icons that are added to Transmission in the future don't need to be added inline but as images in gtk/data (and added to the makefile). The application logo in its various sizes is installed to $PREFIX/share/hicolor, all the other icons to $PREFIX/share/Transmission/icons/hicolor.

I hope you like this, would be nice to have in SVN soon!

Changed 14 years ago by infernux

Patch

comment:2 Changed 14 years ago by charles

I've accepted some of these ideas in r3153 and r3154: particularly the `about' dialog. Also, while looking over your patch, I realized that gtk+ has its own authentication icon, so I've unbundled our own lock icon in preference of gtk+'s.

I'm not sure I understand the choice to bundle an information icon along with Transmission. Is there a problem with the stock GTK+ info icon? In general I'd prefer to use stock GTK+ icons, since more themes are going to support GTK+'s stock than individual applications' icons.

Along that same line of thought, this ticket also has me wondering about how helpful the red and green icons in the torrent inspector really are in the first place -- a new user can probably guess what they mean from context, but it's probably not as helpful as, say, GTK_STOCK_CONNECT and GTK_STOCK_DISCONNECT. What do you think?

Lastly, that leaves the Transmission icon itself. I really like Andreas' icons and am flattered that he's made a Tango icon for Transmission, but IMO the new Transmission icon you've included is not as good as the one currently in use. What about the old icon is unsuitable for Gnome?

comment:3 Changed 14 years ago by infernux

Well... everything you address has a reason:

  • The authentication icon GTK has is gtk-dialog-authentication. It is meant for dialogs and thus only available in 48x48 px. Using it for smaller sizes (16x16 here) results in ugly scaling.
  • Andreas asked me to include the new info icon mainly because the tango info icon is only available in GTK 2.10.. So with older GTK versions, the icon will look out of place.
  • IMHO the red/green dots are fine. Connected/Disconnected? is perhaps not as simple to understand as the red/green "traffic lights". The main problem of using GTK_STOCK_CONNECT/DISCONNECT is that those are meant to be *action* icons for buttons and menus, meaning something you can click to change status, not to just symbolize a status.
  • As for the application icon: There are various things that make the old icon sub-optimal
    • Only available in one (large) size while other sizes are commonly used
    • Not following tango guidelines (perspective, colors, ...)

I agree that the original icon has a more photorealistic look and is better suited as a project logo. But GNOME doesn't use photorealistic icons and tries to have the basic concept of the icon scale well to small sizes. If you compare the old and new icon as being used in the tray or even window title, now you can actually make out what the thing is. The main problem (not looking at how it doesn't fit the style of the rest of the desktop) of the transmission project logo being used as an icon is its strange perspective which makes it look even smaller (by wasting pixels in the corners).

comment:4 Changed 14 years ago by infernux

Ok, let's go for the small solution here first. I prepared another patch against trunk. This time, the original icon is used (scaled to various smaller sizes and the original 16x16 icon as well) and installed. As for show-info, I already explained why it is better to use this over GTK_STOCK_INFO.

Using the separate application icons makes it possible for people to override those without patching and recompiling the application, also transmission doesn't have to scale down the icon for window and tray.

Also the .desktop file is installed. Any suggestions, or can this go onto SVN?

Changed 14 years ago by infernux

Using original project logo as icon

Changed 14 years ago by infernux

Patch to integrate gtk/data into the build

comment:5 Changed 14 years ago by infernux

  • Summary changed from Tango icon theme to Tango application icon

Changing bug, using freedesktop icon spec and actual tango icons is 2 different things

comment:6 Changed 14 years ago by charles

r3339 has the updated desktop file...

comment:7 follow-up: Changed 14 years ago by infernux

What about the rest?

comment:8 in reply to: ↑ 7 Changed 14 years ago by infernux

Replying to infernux:

What about the rest?

The interesting bits are in ticket 376 now

comment:9 Changed 14 years ago by charles

  • Resolution set to fixed
  • Status changed from new to closed

svn trunk is using the tango gtk+ icon now, and darned if it hasn't grown on me. Good call. :)

Note: See TracTickets for help on using tickets.