Opened 12 years ago

Closed 12 years ago

#3488 closed Enhancement (invalid)

Small changes to compact mode

Reported by: username? Owned by: charles
Priority: Lowest Milestone: None Set
Component: GTK+ Client Version: 2.03
Severity: Trivial Keywords:
Cc:

Description

In compact mode:

  • show ratio on paused (but not finished) torrents.
  • change ratio symbol in compact mode to division sign (÷), ive used it for a while and think its pretty.

Attachments (4)

torrent-cell-renderer.c.patch​ (3.9 KB) - added by username? 12 years ago.
util.c.2.patch​ (427 bytes) - added by username? 12 years ago.
util.h.patch​ (419 bytes) - added by username? 12 years ago.
util.c.patch​ (427 bytes) - added by username? 12 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by username?

Hope i did the patch files correctly...

Version 0, edited 12 years ago by username? (next)

Changed 12 years ago by username?

Changed 12 years ago by username?

Changed 12 years ago by username?

Changed 12 years ago by username?

comment:2 Changed 12 years ago by charles

  • Resolution set to invalid
  • Status changed from new to closed
  • Version changed from 2.03+ to 2.03

I appreciate the patch, and notice that it actually cleans up a couple of warts in the code (the broken comment and the duplicate call to test for metadata), but I'm going to pass on using the division symbol because I think it's less intuitive than saying "Ratio." I'm also going to pass on showing the ratio when paused, just as a personal judgement call.

Don't let this scare you off from submitting future patches though.

Note: See TracTickets for help on using tickets.