Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3496 closed Bug (fixed)

Crash when changing to/from compact mode

Reported by: Longinus00 Owned by: Longinus00
Priority: Normal Milestone: 2.10
Component: Qt Client Version: 2.04
Severity: Normal Keywords: backport-2.0x
Cc:

Description

Enabling/disabling compact mode causes the torrent list selection to be cleared. If a Details::refresh happens at the right time then it leads to a crash.

Change History (8)

comment:1 Changed 11 years ago by Longinus00

Add the following check prevents the crash but exposes a related bug where even though the switch to/from compact mode has deselected all the torrents the details window hasn't gone inactive, e.g. it isn't grayed out and is still intractable. A better fix would be to not lose the selection when switching between view modes.

--- qt/details.cc
+++ qt/details.cc
@@ -690,6 +690,7 @@ Details :: refresh( )
         myPeerLimitSpin->blockSignals( false );
     }
 
+    if( !torrents.empty( ) )
     {
         const Torrent * tor;
 

comment:2 Changed 11 years ago by Longinus00

Clearing the selection before resetting the listView may also work around the issue.

comment:3 Changed 11 years ago by charles

  • Owner changed from charles to Longinus00

Longinus00: since it looks like 2.05 isn't going to happen -- if this is still an issue in trunk, do you want to put this under a 2.10 milestone and check in the patch?

comment:4 Changed 11 years ago by Longinus00

There has to be a better way of doing this, I'll look into it.

comment:5 Changed 11 years ago by livings124

  • Milestone changed from 2.05 to 2.10

There's not going to be a 2.05.

comment:6 Changed 11 years ago by Longinus00

  • Resolution set to fixed
  • Status changed from new to closed

Fixed by r11222.

comment:7 Changed 11 years ago by charles

  • Keywords backport-2.0x added

Just to be anal -- there probably will be a 2.05 bugfix release that we don't announce on the frontpage. Otherwise, Ubuntu users won't get another new version of Transmission until April 2011.

comment:8 Changed 11 years ago by charles

backported to 2.0x by r11475

Note: See TracTickets for help on using tickets.