Setting TR_DEBUG environment variable has no effect

[er13]

Setting TR_DEBUG environment variable has no effect as tr_msgInit (s. tr_sessionInit) is called before the following code fragment:

if( tr_bencDictFindInt( clientSettings, TR_PREFS_KEY_MSGLEVEL, &i ) )
  tr_setMessageLevel( i );

The if-condition always evaluates to true as each session always contains a value for TR_PREFS_KEY_MSGLEVEL (it either comes from settings.json or from populating the session with default values in tr_sessionGetDefaultSettings).

Not sure, whether TR_DEBUG-solution is a good one, I would personally prefer a command-line option instead (see attached patch).

[charles]

The logging code is one of my least favorite, cruftiest pieces of libtransmission.

Looking over it with this ticket in mind, I can't see any reason to keep TR_DEBUG alive at all.

If we add a verbosity command-line-argument to the daemon, what it ought to do is poke the value of TR_PREFS_KEY_MSGLEVEL before its call to tr_sessionInit(). Poking the session settings benc dict is how most of the daemon's other arguments are processed already.

[charles]

Fixed in trunk by r11249, r11250

[charles]

and r11251 for good measure, too

[er13]

@charles: may I ask you a question, why did you call the option log-err and not log-error? Could you please rename it to log-error just for the sake of consistency with two other logging options - log-debug(not dbg) & log-info(not inf)? Thanx ;-)

[charles]

I think we're wandering close to bikeshed territory here, but... okay. r11254