Opened 11 years ago

Closed 11 years ago

#3513 closed Bug (fixed)

inactive limit should set torrent state as finished, not stopped

Reported by: leena Owned by: livings124
Priority: Normal Milestone:
Component: libtransmission Version: 2.04+
Severity: Normal Keywords:
Cc:

Description

When the inactive limit is reached, the torrent is marked as stopped, but should be marked as finished. This is how the ratio limit behaves.

Change History (5)

comment:1 Changed 11 years ago by livings124

  • Milestone changed from None Set to 2.10
  • Version changed from 2.04 to 2.04+

comment:2 Changed 11 years ago by leena

Isn't it as simple as the following? It works for me.

Index: torrent.c
===================================================================
--- torrent.c	(revision 11200)
+++ torrent.c	(working copy)
@@ -1199,10 +1199,11 @@
             break;
     }
 
-    #warning (maybe) do something for idle?
     /* s->haveValid is here to make sure a torrent isn't marked 'finished'
      * when the user hits "uncheck all" prior to starting the torrent... */
     s->finished = seedRatioApplies && !seedRatioBytesLeft && s->haveValid;
+    if (!s->finished && tr_torrentIsSeedIdleLimitDone( tor ))
+        s->finished = TRUE;
 
     if( !seedRatioApplies || s->finished )
         s->seedRatioPercentDone = 1;

comment:3 Changed 11 years ago by livings124

That doesn't take into consideration that the app could've been quit and then started with paused transfers.

comment:4 Changed 11 years ago by livings124

  • Component changed from Transmission to libtransmission
  • Milestone 2.10 deleted
  • Owner set to livings124

comment:5 Changed 11 years ago by livings124

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.