Opened 10 years ago

Closed 10 years ago

#3547 closed Bug (fixed)

Wrong speed display in web UI

Reported by: KyleK Owned by: charles
Priority: Normal Milestone:
Component: Transmission Version: 2.04+
Severity: Normal Keywords:
Cc:

Description

With r11194 the unit of up- and download speeds that are sent through RPC were changed again, but the daemon (rather the remote) and the Web UI were not informed about those changes :)

Result is they both show very wrong speeds.

Attachments (2)

daemon_speeds_v2.patch (1.4 KB) - added by KyleK 10 years ago.
Picture 1.png (143.2 KB) - added by r0n1n 10 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 years ago by charles

  • Milestone None Set deleted
  • Owner set to charles
  • Status changed from new to assigned
  • Version changed from 2.04 to 2.04+

Thanks KyleK!

comment:2 Changed 10 years ago by KyleK

It seems you missed some places in transmission-remote which were also affected by the speed unit change.

Here's a patch.

Changed 10 years ago by KyleK

comment:3 Changed 10 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

Nice catch. Thanks KyleK!

Fixed in trunk by r11205

comment:4 Changed 10 years ago by gunzip

  • Resolution fixed deleted
  • Status changed from closed to reopened

OS Linux Debian, transmission-daemon 2.04+ (11206)

When running transmission-remote for peer info,i.e.

transmission-remote -t <ID> -pi

the Up/Down? speed units are not consistent

comment:5 Changed 10 years ago by charles

-pi fixed in r11213

Please reopen this ticket if there are any remaining problems. And, thanks to both of you for looking over my shoulder to check my work... :)

comment:6 Changed 10 years ago by charles

  • Resolution set to fixed
  • Status changed from reopened to closed

comment:7 Changed 10 years ago by r0n1n

  • Resolution fixed deleted
  • Status changed from closed to reopened

Noticed the web UI is off by 2 kB/s, using r11218.

Changed 10 years ago by r0n1n

comment:8 follow-up: Changed 10 years ago by livings124

This appears to be a case of the Mac app using base 10 and the web ui using base 2.

comment:9 in reply to: ↑ 8 Changed 10 years ago by r0n1n

Replying to livings124:

This appears to be a case of the Mac app using base 10 and the web ui using base 2.

Isn't base 10 for 10.6 systems? I'm using 10.5.8.

comment:10 Changed 10 years ago by livings124

  • Milestone set to 2.10

You're right I inverted it. The Mac app is using base 2, the web ui is using base 10. That's why the web ui appears to be downloading faster. Also, notice that the web ui is showing kB/s instead of KB/s, as the Mac ui specifies.

comment:11 Changed 10 years ago by charles

  • Milestone 2.10 deleted
  • Resolution set to fixed
  • Status changed from reopened to closed
  • Summary changed from Regression: Wrong speed display in transmission-remote and web UI to Wrong speed display in web UI

The web client's fixed in trunk by r11228.

I'm not going to fix this in transmission-remote -- that app executes once and then exits, so it's kind of crazy to add a new round trip to the RPC server just for this.

...well, it's not outside the realm of possibility. But I'll wait for end users to complain before I can justify that extra round trip.

Last edited 10 years ago by charles (previous) (diff)
Note: See TracTickets for help on using tickets.