Changes between Version 1 and Version 2 of Ticket #3596, comment 6


Ignore:
Timestamp:
Oct 12, 2010, 3:13:53 PM (12 years ago)
Author:
charles
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #3596, comment 6

    v1 v2  
    77Yes.  Previously peer-msgs.c had an implicit interval that silently ignored requests that came too frequently from peer-mgr.c.  The periods can be revised but the larger point is to remove the implicit interval and consolidate all the logic into the peer-mgr unchoke timer.
    88
    9 Now, about revising the periods -- it's likely that 30 seconds may be too long of an interval for unchoked, non-optimistic peers.  And choke periods could be evaluated separately from optimistic and non-optimistic choke periods.  Possibly there shouldn't be any minimum choke period at all if there aren't enough reachable peers.
     9Now, about revising the periods -- maybe 30 seconds is too long for non-optimistic unchokes.  And chokes could be handled separately from both kinds of unchokes -- possibly with no minimum choke interval at all.
    1010
    1111Attached is a revised patch which enforces no interval on choked peers, a 30 second minimum for optimistic unchokes, and a 20 second minimum on non-optimistic unchokes.