Opened 11 years ago

Closed 8 years ago

Last modified 7 years ago

#3606 closed Bug (fixed)

Qt client New Torrent from Source Folder is Goofy

Reported by: Lacrocivious Owned by: mike.dld
Priority: Normal Milestone: 2.83
Component: Qt Client Version: 2.04
Severity: Normal Keywords: backport-2.8x qt create new torrent patch
Cc:

Description

There are two problems with New Torrent creation in the Qt client.

Problem 1: It is not possible to create a torrent from a source directory and name that torrent, or if you name the torrent, it is not possible to create the torrent at all.

Problem 2: Parts of the Qt client's torrent creation dialogs act on a single click even if double click is selected in the (KDE) desktop environment user interface.

In this instance Transmission is svn trunk r11290, running Linux 2.6.32.21-168.fc12.i686.PAE #1 SMP Wed Sep 15 16:18:39 UTC 2010 i686 athlon i386 GNU/Linux, under KDE 4.4.5-1.fc12.

File/New? Torrent: New Torrent dialog appears

Save to: Browsable and selectable, but selection actions are single-click instead of double-click as selected in the DE preferences.

Source Folder: Browsable and selectable, but in single-click activation mode and not in a manner consistent with the expected interface. The source folder must be opened rather than highlighted, and its name never appears in the 'Name' field at the bottom of the dialog. This does, however, include in the .torrent file about to be created the files and folder desired -- which is odd because that folder has been opened and should normally not include itself. Note that no files are displayed. At this point it is possible to pretend you have given the torrent a name (you have not) and continue as if the interface showed you what you expected. The .torrent file created will always be named '.torrent'. If opened in a torrent file viewer, the desired files will be seen included.

At the point above when the source folder has been opened and shows no files, if you manually enter a name for the torrent in the 'Name:' field and continue, at the point where the dialog 'New Torrent <2>' appears with a button to create the .torrent file, the error message: 'Error reading "" No such file or directory' appears. No .torrent file is created.

The single-click action where double-click action is defined in the DE's preferences and expected by the user, can easily result in multiple 'New Torrent' dialogs onscreen.

Repeated attempts to navigate to the desired directory and create a new torrent will eventually -- after two to four attempts -- lock up Transmission and require a pid kill.

Attachments (1)

3606-remove-trailing-slash.patch (1.4 KB) - added by mike.dld 8 years ago.

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by mike.dld

comment:1 Changed 8 years ago by mike.dld

  • Owner changed from charles to mike.dld

QFileDialog may return path containing trailing slash for selected directory in some cases, specifically seen when running transmission-qt in KDE, but not in Unity or Xfce. When such path is used to construct QFileInfo, fileName() method would then return an empty string which is being further used as button title.

Attached patch strips that trailing slash so that fileName() returns valid directory name.

comment:2 Changed 8 years ago by mike.dld

As a reminder, it has been discussed with Lacrocivious in IRC that it would be great if this dialog would also warn user in case torrent file being created would overwrite existing file. IMHO we could remove target directory selection button and show user a "save torrent as" file selection dialog (on "OK" button click) initially filled with automatically generated torrent file path and name (the same way it's being generated right now). The dialog would not only check by itself whether any file would be overwritten but also allow user to customize torrent file name.

comment:3 Changed 8 years ago by mike.dld

  • Keywords patch added

comment:4 Changed 8 years ago by mike.dld

  • Status changed from new to assigned

comment:5 Changed 8 years ago by jordan

  • Keywords backport-2.8x added
  • Milestone changed from None Set to 2.90
  • Resolution set to fixed
  • Status changed from assigned to closed

comment:2 makes sense to me, but for bookkeeping's sake Lacrocivious could you split that off into a separate ticket.

"New Torrent from Source Folder is Goofy" is too broad a description for one ticket, it's begging for sprawl :)

comment:6 Changed 7 years ago by livings124

  • Milestone changed from 2.90 to 2.83
Note: See TracTickets for help on using tickets.