Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3627 closed Bug (fixed)

off-by-one in FileTreeView causes potential invalid memory read / crash

Reported by: charles Owned by: charles
Priority: Normal Milestone: 2.11
Component: Qt Client Version: 2.10
Severity: Major Keywords: backport-2.0x
Cc:

Description

Index: file-tree.cc
===================================================================
--- file-tree.cc	(revision 11297)
+++ file-tree.cc	(working copy)
@@ -641,7 +641,7 @@
     sortByColumn( COL_NAME, Qt::AscendingOrder );
     installEventFilter( this );
 
-    for( int i=0; i<=NUM_COLUMNS; ++i )
+    for( int i=0; i<NUM_COLUMNS; ++i )
         header()->setResizeMode( i, QHeaderView::Fixed );
 
     connect( this, SIGNAL(clicked(const QModelIndex&)),

Change History (3)

comment:1 Changed 11 years ago by charles

  • Status changed from new to assigned

comment:2 Changed 11 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in trunk by r11306

comment:3 Changed 11 years ago by charles

backported to 2.0x by r11476

Note: See TracTickets for help on using tickets.