script-torrent-done executed too early

[mactijn]

Currently, when a torrent is done downloading, a script is being triggered and then verification is started, which creates a race condition where the script might be accessing corrupted data.

Situation

• {config::script-torrent-done-enabled}: true
• {config::script-torrent-done-filename}: (set to script)
• {config::incomplete-dir-enabled}: true
• {config::incomplete-dir}: (set to dir)
• {config::download-dir}: (set to dir)

Current behavior

• a torrented download finishes
• data is moved to {config::download-dir} from {config::incomplete-dir}
• a script is executed
• verification of the data is started
• possible corrupted pieces are re-downloaded

Expected behavior

• a torrented download finishes
• data is moved to {config::download-dir} from {config::incomplete-dir}
• verification of the data is started
  • corruption is found
    • corrupted pieces are re-downloaded
    • restart verification
  • corruption is not found
    • a script is executed

[mactijn]

not verified yet on 2.11 since I just installed this. Changelogs suggest this behavior has not been altered.

[mactijn]

The same behavior is observed on 2.11 and nightly builds.

[charles]

This will be fixed by changing how Transmission verifies torrents as per ticket #2955. Closing this as a duplicate of #2955.