Opened 12 years ago

Closed 12 years ago

#3666 closed Bug (fixed)

byteCount stored on a 32bits integer

Reported by: iuo487 Owned by: charles
Priority: Normal Milestone: 2.12
Component: libtransmission Version: 2.10
Severity: Minor Keywords:
Cc:

Description

Hello, I noticed that the number of bytes uploaded/downloaded between two announce is stored in a 32bit unsigned integer. It could become a problem on very fast connections (seedboxes ?). It was stored in an uint64 until r10918.

I'm not sure it's really a bug...

Regards iuo487

Attachments (1)

announcer.diff​ (1.8 KB) - added by charles 12 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 12 years ago by charles

  • Component changed from Transmission to libtransmission
  • Milestone changed from None Set to 2.12
  • Owner set to charles
  • Status changed from new to assigned
  • Version changed from 2.11+ to 1.92

comment:2 Changed 12 years ago by charles

  • Version changed from 1.92 to 2.10

Looks like this bug was introduced in 2.10

Last edited 12 years ago by charles (previous) (diff)

Changed 12 years ago by charles

comment:3 Changed 12 years ago by charles

iuo487, could you give this patch a test and see if it looks/works right to you?

comment:4 Changed 12 years ago by iuo487

Well, the patch looks right, but i wasn't able to find a torrent fast and big enough to actually trigger the bug.

comment:5 Changed 12 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in trunk for r11354.

Note: See TracTickets for help on using tickets.