Opened 11 years ago

Closed 11 years ago

#3671 closed Bug (fixed)

web client regression: new use of Array.indexOf() breaks in IE7 and IE8

Reported by: Michael Zoon Owned by: charles
Priority: Normal Milestone: 2.12
Component: Web Client Version: 2.11
Severity: Normal Keywords:
Cc:

Description

There is a bug introduced by this change for IE browsers

this is the change made; https://trac.transmissionbt.com/changeset/11305/trunk/web/javascript/transmission.js

IE8 now only will show "NA" in the browser under tab information and Activity when using the inspector.

Regards, Michael Zoon Developer FreeNAS

Attachments (2)

common.js (8.7 KB) - added by charles 11 years ago.
common.diff (549 bytes) - added by charles 11 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 years ago by Michael Zoon

  • Priority changed from Normal to High

comment:2 Changed 11 years ago by charles

Why is that the case? I don't see the error in that diff.

comment:3 Changed 11 years ago by Michael Zoon

well, if i use the older transmission.js in 2.11 it works as it should be, and load again the 2.11 transmsission.js it shows again NA.

also browser report error on line 1315, the change is really tha one that change the output to NA only

comment:4 Changed 11 years ago by charles

Hi Michael,

Well I'd like to fix the bug rather than revert the commit. Could you tell me the error message that IE8 gives for line 1315?

comment:5 Changed 11 years ago by Michael Zoon

it says on line 1315 sign 4 as fault on transmission.js

Regards, Michael Zoon

comment:6 Changed 11 years ago by charles

Ah, I see the problem. According to this page IE didn't support Array.indexOf until IE9.

It also has a suggested fix. Could you try replacing your version of common.js with the one I'm attaching to this ticket to see if it fixes the problem for you?

Changed 11 years ago by charles

Changed 11 years ago by charles

comment:7 Changed 11 years ago by Michael Zoon

Thanks for diving into this problem,

The common.js above makes all working again on 2.11.

Regards, Michael Zoon

comment:8 Changed 11 years ago by charles

  • Component changed from Transmission to Web Client
  • Milestone changed from None Set to 2.12
  • Owner set to charles
  • Priority changed from High to Normal
  • Status changed from new to assigned

comment:9 Changed 11 years ago by charles

  • Status changed from assigned to new
  • Summary changed from IE 8 bug transmission 2.11 Inspector Output. to web client regression: new use of Array.indexOf() breaks in IE7 and IE8

comment:10 Changed 11 years ago by charles

  • Status changed from new to assigned

comment:11 Changed 11 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r11355

Note: See TracTickets for help on using tickets.