Opened 11 years ago

Closed 11 years ago

#3719 closed Enhancement (fixed)

Handle API changes to libnotify 0.7

Reported by: charles Owned by: charles
Priority: Normal Milestone: 2.20
Component: GTK+ Client Version: 2.11
Severity: Normal Keywords:
Cc:

Description

http://lists.fedoraproject.org/pipermail/devel/2010-November/144914.html

I am planning to push libnotify 0.7.0 into rawhide by the end of this
week; this is going to be a little painful, since there are some api
changes that will require minor adjustment of all users. And there's
quite a few of them (see below). I will hopefully be able to handle most
of the GNOME dependencies, for the rest I need to ask for some help.

Scratch builds of libnotify 0.7.0 rpms can be found here:
http://mclasen.fedorapeople.org/libnotify/

Here is an overview of the api changes:

notify_notification_new_with_status_icon   is gone
notify_notification_attach_to_status_icon  is gone
notify_notification_attach_to_widget       is gone
notify_notification_set_geometry_hints     is gone
notify_notification_new                    has lost its widget argument

A typical patch will look like this one:
https://bugzilla.gnome.org/review?bug=632327&attachment=172525

For some background on these changes, see
http://live.gnome.org/GnomeShell/Design/Guidelines/MessageTray/Compatibility

Attachments (1)

libnotify.patch (728 bytes) - added by _v_l 11 years ago.
Patch for libnotify 0.7 (gtk/notify.c, function that add torrent)

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by charles

  • Status changed from new to assigned

Fixed in trunk by r11387

comment:2 Changed 11 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed

Changed 11 years ago by _v_l

Patch for libnotify 0.7 (gtk/notify.c, function that add torrent)

comment:3 Changed 11 years ago by _v_l

Hi. Seems that your fotgot about function that add torrent ("Torrent Added"). I attach the patch.

comment:4 Changed 11 years ago by charles

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:5 Changed 11 years ago by charles

d'oh!

thanks

comment:6 Changed 11 years ago by charles

  • Milestone changed from 2.12 to 2.20
  • Status changed from reopened to new

comment:7 Changed 11 years ago by charles

  • Status changed from new to assigned

Fixed in trunk by r11511

comment:8 Changed 11 years ago by charles

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.