Opened 14 years ago

Closed 14 years ago

#382 closed Bug (fixed)

move data location without it existing

Reported by: jah Owned by: livings124
Priority: Normal Milestone: None Set
Component: Mac Client Version: 0.82+
Severity: Normal Keywords:
Cc:

Description

useful if for whatever reason you have moved a data file to a new location.

Attachments (1)

patch.diff (814 bytes) - added by tiennou 14 years ago.
Patch !

Download all attachments as: .zip

Change History (9)

comment:1 Changed 14 years ago by livings124

  • Resolution set to wontfix
  • Status changed from new to closed

You can change the location in the File menu. This would just make it less aesthetically-pleasing.

comment:2 Changed 14 years ago by jah

  • Resolution wontfix deleted
  • Status changed from closed to reopened
  • Type changed from Enhancement to Bug Report

if you move the data file, and then click the magnifying glass in the inspector, it just switches to finder, but does nothing (as the file is obviously not there). I would consider this a bug.

What could possibly happen is if T cant find the data file, a box should come up stating that fact, and allow you to tell T where it is. Similar to resolving aliases in the finder, or missing dock items.

comment:3 Changed 14 years ago by jah

also, you can't change the location in the file menu, if you have already moved the file in the finder. it just comes up with an error. the only way is to remove the torrent and then re-add it, telling T where to download to (ie the new location).

comment:4 Changed 14 years ago by livings124

  • Summary changed from make 'data file location' in inspector editable to move data location without it existing

comment:5 Changed 14 years ago by livings124

  • Component changed from Transmission to OS X Interface

comment:6 Changed 14 years ago by tiennou

you can make this quickly by adding a test at Torrent.m:434, which will become :

if (NSFileManager defaultManager] movePath: [oldFolder stringByAppendingPathComponent: [self name? toPath: [folder stringByAppendingPathComponent: [self name]] handler: nil]

NSFileManager defaultManager] fileExistsAtPath:[oldFolder stringByAppendingPathComponent: [self name?] == NO)

Now if the old folder didn't exists, the move still takes place...

comment:7 Changed 14 years ago by tiennou

Sorry trac messed it up, or I should "Preview" more often ;-)

        if ([[NSFileManager defaultManager] movePath: [oldFolder stringByAppendingPathComponent: [self name]]
toPath: [folder stringByAppendingPathComponent: [self name]]
handler: nil] || [[NSFileManager defaultManager] fileExistsAtPath:[oldFolder stringByAppendingPathComponent: [self name]]] == NO)

Changed 14 years ago by tiennou

Patch !

comment:8 Changed 14 years ago by livings124

  • Resolution set to fixed
  • Status changed from reopened to closed

fixed in [3919]

Note: See TracTickets for help on using tickets.