Opened 14 years ago

Closed 14 years ago

#384 closed Bug (invalid)

don't let pex peers flood our local pool

Reported by: jah Owned by:
Priority: Normal Milestone: None Set
Component: libtransmission Version: 0.82
Severity: Normal Keywords:
Cc:

Description

T should always maintain some 'external' peers to the ones it gains from pex (either from the tracker or incomings) so that the situation doesnt arise whereby all our peers are pex. This is a bad situation as it means our download speed is compromised due to the peers we get not being random.

A possible method (which is what was done originally) is to cap the number of pex peers below the max rate.

Change History (7)

comment:1 Changed 14 years ago by persept

Capping the amount of PEX peers will only reduce the number of peers we are connected to. It might be useful to set a ratio of PEX to Tracker acquired peers. Example: If we know 100 peers from only the tracker and 200 peers from PEX, try to connect to 2 tracker peers for every 1 peer from PEX we try to connect to. If we know 50 peers from the tracker and 10 peers from PEX, connect to 5 PEX peers for every 1 peer from the tracker. My point being, connect to the rarer peers first.

comment:2 Changed 14 years ago by charles

  • Owner charles deleted

Is this actually a real problem that anyone's experiencing? I would think that the transfer rates are more important than where the peers actually come from...

comment:3 Changed 14 years ago by charles

jah, persept: ping

comment:4 Changed 14 years ago by charles

  • Resolution set to invalid
  • Status changed from new to closed

after talking this over with persept, I still don't see the point of such a feature.

jah, if you have more to add, feel free to reopen this ticket so that I'll see it. :)

comment:5 Changed 14 years ago by jah

  • Resolution invalid deleted
  • Status changed from closed to reopened

it is not necessarily a bit problem, however given the discussion here http://dosirrah.livejournal.com/995.html

it might be worth looking into.

Essentially what it is saying is that if you rely too much on PEX, there could be better peers in the swarm that you could have got from the tracker, but which you can never know about. Furthermore, for the good of the total swarm, it is unfavourable to have too much inter peer gossip as you could get a situation where the total swarm is broken into separate 'mini swarms' who cannot talk and connect to each others peers.

NB: i only reopened the ticket so that you could see my comment, feel free to close it again. ;)

comment:6 Changed 14 years ago by jah

persept, given T's peer connection limits are fixed (at 60 right?) wouldnt a ratio just be the same as setting a cap?

comment:7 Changed 14 years ago by charles

  • Resolution set to invalid
  • Status changed from reopened to closed

If a peer doesn't give a satisfactory transfer rate, we drop it in favor of another peer. In light of that, I still don't see why peers from the tracker need special attention -- if the pex peers are good enough, there's no problem. if they're not good enough, we'll use the tracker's...

Note: See TracTickets for help on using tickets.