memory leak in torrentCallScript

[ijuxda]

This function uses tr_strdup* to setup the cmd and env strings, but I cannot for the love of me see where this memory is freed. I'm sort of hoping there are some interesting fork/exec semantics I don't know about, but maybe this is just a mistake.

[charles]

Well the libtransmission thread can't free it, because it never knows when the fork is done.

The fork can't free it, because execve never returns except on error.

I dont think we can use alloca() because the stack memory isn't valid once the libtransmission thread exits torrentCallScript().

We /could/ use the forked pid as a key to some static lookup table, and then use the key in onSigCHLD to free the variables, but when I thought about the relative infrequency of torrentCallScript() being invoked, and thought about the pid-lookup scaffolding... leaking a few bytes seemed like a decent tradeoff. :)

If you want to patch it to handle things in onSigCHLD(), please reopen this ticket and I'll use the patch.

[charles]

I'm an idiot, fork() makes its own copy of the memory, so the version allocated in the main process should be safe to be freed in the main process.

[charles]

r11605

[charles]

seems to be working.