Opened 11 years ago

Closed 11 years ago

#3881 closed Bug (fixed)

Right click torrent context menu does not work with Firefox / Firegestures / Ubuntu

Reported by: dino541 Owned by: dino541
Priority: Normal Milestone: 2.20
Component: Web Client Version: 2.13
Severity: Minor Keywords:
Cc:

Description

See https://forum.transmissionbt.com/viewtopic.php?f=8&t=11098&p=51627.

In Ubuntu Lucid, Firefox with Firegestures installed prevents torrent right-click contextual menu from appearing at all.

JQuery Context Menu plugin which controls the menu is quite old (3+ years) and may be in need of upgrading (it was originally designed to support JQuery 1.1, Firefox 1.5, and IE 6.)

Perhaps an upgrade to http://abeautifulsite.net/blog/2008/09/jquery-context-menu-plugin/ is worthwhile? This context menu plugin was last updated in March 2010, so it's under a year old and works with all of the main browsers.

I wrote a patch for this in case anyone is interested in using a new context menu... of course please let me know if anyone has concerns about it and I'll be happy to adjust / refactor.

Attachments (3)

dino541.patch (19.8 KB) - added by dino541 11 years ago.
dino541.2.patch (19.8 KB) - added by dino541 11 years ago.
dino541.3.patch (6.2 KB) - added by dino541 11 years ago.

Download all attachments as: .zip

Change History (12)

Changed 11 years ago by dino541

comment:1 Changed 11 years ago by jordan

dino541, as an aside, there is a "next-generation" web client in development that's currently stalled largely because we don't have any developers that can do web layout / css very well. The javascript coding is fairly good, but it needs work in the looks department. Is that something that you would be interested in?

comment:2 Changed 11 years ago by livings124

The one thing that bugs me with this is that the current context menu matches the system's context menu in terms of looks, while this new one does not. Is there a way to get that behavior?

Changed 11 years ago by dino541

comment:3 Changed 11 years ago by dino541

No problem - sorry to make you view this patch twice! The new dino541.2.patch should match up with the existing style.

comment:4 Changed 11 years ago by livings124

I noticed it doesn't close when clicking on the screen (Safari 5.0.3).

Changed 11 years ago by dino541

comment:5 Changed 11 years ago by dino541

Let's give patch 3 a whirl (dino541.3.patch). Turns out that the newer context menu plugin that I tried to use isn't Safari 5 compatible. Plus, considering jordan's comment that you guys have a new UI in the works, I decided to not reinvent the wheel with this and just fix the little problem at hand.

Jordan, I'm afraid that while I'm fairly good with JQuery / Javascript, CSS any layout work is not one of my strengths. If any Javascript or other things come up with the new web UI come up, I'm happy to take a look, but I don't think I'm the person you're looking for with respect to CSS styling.

comment:6 Changed 11 years ago by livings124

  • Milestone changed from None Set to 2.20
  • Resolution set to fixed
  • Status changed from new to closed

Thanks for the patch! r11679

comment:7 Changed 11 years ago by jordan

  • Resolution fixed deleted
  • Status changed from closed to reopened

reopened for attribution

comment:8 Changed 11 years ago by jordan

  • Owner set to dino541
  • Status changed from reopened to new

comment:9 Changed 11 years ago by jordan

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.