Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3894 closed Enhancement (fixed)

tr_peerIo.hasFinishedConnecting is unnecessary

Reported by: jordan Owned by: jordan
Priority: Normal Milestone: 2.20
Component: libtransmission Version: 2.13
Severity: Minor Keywords:


Recently I went back into the forums, irc logs, and svn logs to find out why peerIo.hasFinishedConnecting exists. It was added on 19 Jan 2009 in r7747. There's no ticket number in the commit log, but looking through logs it's clearly in reference to ticket #1734 was opened a couple of days later.

The commit message to r7747 indicates that it was an experimental patch to address the problem. It doesn't appear to have any bearing on #1734's fix and was probably left in by accident.

I've tried removing it and don't see any negative effects, so the next step is to check it into the svn trunk for nightly build testing.

Change History (6)

comment:1 Changed 11 years ago by x190


Lest Ye Forget! :)

comment:2 Changed 11 years ago by jordan

I could have found that out for myself in 2013...

comment:3 Changed 11 years ago by jordan

  • Status changed from new to assigned

comment:4 Changed 11 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:5 Changed 11 years ago by jordan

  • Summary changed from tr_peerIo.hasFinishedConnecting should be removed to tr_peerIo.hasFinishedConnecting is unnecessary

comment:6 Changed 11 years ago by jordan

  • Type changed from Bug to Enhancement
Note: See TracTickets for help on using tickets.