Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3906 closed Bug (fixed)

DHT should use bind-address-ipv6

Reported by: simon Owned by: jordan
Priority: Normal Milestone: 2.20
Component: libtransmission Version: 2.11
Severity: Normal Keywords: dht ipv6
Cc: jch@…

Description

The DHT service binds to whatever the default source IPv6 address is, ignoring the bind-address-ipv6 option. It should bind to the configured IPv6 address.

Change History (10)

comment:1 Changed 11 years ago by jordan

  • Cc jch@… added

comment:2 Changed 11 years ago by jordan

Juliusz, do you have any opinion on this?

comment:3 Changed 11 years ago by jch

I confirm. That's a bug.

Should be easy to fix, just hack at tr-udp.c and modify rebind to take bind-address-ipv6 into account.

--jch

comment:4 Changed 11 years ago by jordan

r11749 (trunk libT) #3906 "DHT ignores bind-address-ipv6" -- test fix.

Add code to honor the ipv6 bind address. Thanks to jch for saving me a little work by confirming the bug and pointing out where in the code the change needed to be made.

Last edited 11 years ago by jordan (previous) (diff)

comment:5 Changed 11 years ago by jordan

Simon, could you try a nightly build from https://build.transmissionbt.com/job/trunk-linux/ or https://build.transmissionbt.com/job/trunk-mac/ and confirm this change?

comment:6 Changed 11 years ago by jch

Hmm... so now the v4 address is passed as a parameter to udpInit (see r8881), while the v6 address is grabbed directly from the tr_session. Either strategy is fine with me (I actually have a small preference to yours over gornack's), but please be consistent.

--jch

comment:7 Changed 11 years ago by jordan

r11752

libtransmission/ (session.c tr-udp.c tr-udp.h): #3906 "DHT ignores bind-address-ipv6" -- make the process of getting the binding address consistent between IPv4 and IPv6 sockets.

As suggested by Juiusz after the IPv6 binding commit in r11749. See: https://trac.transmissionbt.com/ticket/3906#comment:6

comment:8 Changed 11 years ago by jordan

  • Milestone changed from None Set to 2.20
  • Status changed from new to assigned

comment:9 Changed 11 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:10 Changed 11 years ago by jordan

  • Summary changed from DHT ignores bind-address-ipv6 to DHT should use bind-address-ipv6
Note: See TracTickets for help on using tickets.