Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3911 closed Bug (fixed)

tr_peerMgrTorrentAvailability() doesn't sample across the entire torrent

Reported by: jordan Owned by: jordan
Priority: Normal Milestone: 2.20
Component: libtransmission Version: 2.13
Severity: Minor Keywords: backport-2.1x backport-2.0x
Cc:

Description (last modified by jordan)

Source: ijuxda

The wrong argument is passed to tr_bitsetHas(), causing the first parts of the torrent to be sampled, but not the end of the torrent.

Simple fix:

Index: peer-mgr.c
===================================================================
--- peer-mgr.c	(revision 11702)
+++ peer-mgr.c	(working copy)
@@ -2164,7 +2164,7 @@
         else if( peerCount ) {
             int j;
             for( j = 0; j < peerCount; ++j )
-                if( tr_bitsetHas( &peers[j]->have, i ) )
+                if( tr_bitsetHas( &peers[j]->have, piece ) )
                     ++tab[i];
         }
     }

Change History (4)

comment:1 Changed 11 years ago by jordan

  • Component changed from Transmission to libtransmission
  • Description modified (diff)
  • Keywords backport-2.1x backport-2.0x added; maybe-backport-2.1x maybe-backport-2.0x removed
  • Owner set to jordan
  • Status changed from new to assigned

comment:2 Changed 11 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r11703

comment:3 Changed 11 years ago by jordan

  • Severity changed from Normal to Minor

comment:4 Changed 11 years ago by jordan

  • Description modified (diff)
Note: See TracTickets for help on using tickets.